CC-2137 NZSL: move signbank to Poetry - round 3 #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing for some reason. Converted to Draft. |
|
Ah, I believe we may have a case of this |
|
Turns out the |
|
Closing this PR and branch as it's just becoming a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
CC-2137 NZSL: move signbank to Poetry
Changes
path()override implemented as is now required in custom Storage backendsgunicornpinned due toWorker (no URI read) issueError handling request (no URI read) benoitc/gunicorn#3207s3 botoupdates changing method behaviour slightlyNotes
poetryconversion complete, but Micky found she could not add newglosses. Hopefully this PR fixes the remainingpoetryconversion issues.