-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add resource schema and resource_locations to ocrd-tool.json schema #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should probably be addressed here, too:
|
bertsky
reviewed
Feb 2, 2022
there should be no need to register these, though |
bertsky
reviewed
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the ocrd_tool.md needs to be updated as well:
- mention the
resources
andresource_locations
under theFile parameters
section - show them in the examples
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
…nto resources-ocrd-tool
…nto resources-ocrd-tool
6 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new properties to the
tools
list items inocrd-tool.json
:resources
: List resources that can be used with this processor, to be used with OCR-D/core'socrd resmgr
CLI and resource lookup mechanismresource_locations
: By default, resource's are looked up indata
($XDG_DATA_HOME
),cwd
andsystem
(/usr/local/share/ocrd-resources
). Since not all processors can support the full range of locations (notably ocrd_tesserocr can look only in one location for models), this allows restricting the locations to look for this processor.Until now, we're maintaining a central resource registry in OCR-D/core. We want to decentralize this, allowing processor developers to list resources in their own ocrd-tool.json.