Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.get_nth_textequiv: respect @index #32

Merged
merged 2 commits into from
Sep 13, 2022
Merged

utils.get_nth_textequiv: respect @index #32

merged 2 commits into from
Sep 13, 2022

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Sep 12, 2022

Fix #31

@bertsky bertsky requested a review from kba September 12, 2022 13:07
@bertsky
Copy link
Collaborator Author

bertsky commented Sep 12, 2022

Note: I also had to change the --textequiv-fallback-strategy default from last to first, since

  • the default --textequiv-index of zero now means @index="0", not position zero, so if no @index is available we would need the fallback
  • OCR-D processors always consume the first by default, so it's unexpected to see last as default here

@kba kba merged commit be1cfd1 into master Sep 13, 2022
@bertsky bertsky mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textequiv_index is not @index but element position
2 participants
@bertsky @kba