disable tensorflow/keras print-to-stdout with tf_disable_interactive_… #90
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 85.38% 4.70% -80.68%
==========================================
Files 3 3
Lines 171 170 -1
Branches 39 39
==========================================
- Hits 146 8 -138
- Misses 15 162 +147
+ Partials 10 0 -10
|
|
(The code coverage result is weird) |
|
Broken for Python 3.6: Python 3.6 is EOL since 2021-12-23, so it's time to say goodbye 😢 |
(See also #90 where it came up.)
That version was dropped in core as well. |
config.py's TF_CPP_MIN_LOG_LEVEL was removed but recognize.py not adapted accordingly. Fix this by removing the use of the variable there as well.
mikegerber
force-pushed
the
tf_disable_interactive_logs
branch
from
2ea9780 to
637a08d
Compare
|
I removed testing on Python 3.6 in master and rebased this PR. This fixed it! 🚀 |
|
Manual test also works now. There's some weird |
|
This required |
|
@MehmedGIT How would I (easily) test if this problem comes up again? Run the network/processing server? I'm doing some code janitor work for #92 and this also involves some sorting of the import blocks. I disabled sorting for the block that disables interactive logs + imports TF + Calamari but I'd like to make sure. |
|
@mikegerber, check here: https://pad.gwdg.de/Ty6IXzhIRa6AvDdC4kTy_g |
Thanks. I will test another time - that's a bit more work than I had anticipated. A normal CLI call does not spew out any TF/Keras output, so I'm somewhat confident that's also OK within the processing server. |
…logs, OCR-D/core#1091