Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OcrdMets.add_agent: insert before metsDocumentID #977

Merged
merged 3 commits into from
Mar 13, 2023
Merged

OcrdMets.add_agent: insert before metsDocumentID #977

merged 3 commits into from
Mar 13, 2023

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Feb 3, 2023

fixes #976 (but you may want to add a test case, featuring some document with existing mets:metsDocumentID and optionally also mets:agents)

@bertsky bertsky requested a review from kba February 3, 2023 14:50
@kba kba merged commit b5c5691 into master Mar 13, 2023
@kba kba deleted the fix-add-agent branch March 13, 2023 11:43
@kba
Copy link
Member

kba commented Mar 13, 2023

added a test, works as expected, thank you @bertsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add_agent creates invalid METS if metsHdr exists
2 participants
@bertsky @kba