Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise ValueError if --page-id is provided but leads to empty result #1089

Merged
merged 3 commits into from
Sep 11, 2023
Merged

raise ValueError if --page-id is provided but leads to empty result #1089

merged 3 commits into from
Sep 11, 2023

Conversation

kba
Copy link
Member

@kba kba commented Sep 8, 2023

No description provided.

@kba kba requested a review from MehmedGIT September 8, 2023 11:41
@kba kba linked an issue Sep 8, 2023 that may be closed by this pull request
Provide a warning if --page-id evaluates to an empty set #1088
Closed
@kba
Copy link
Member Author

kba commented Sep 11, 2023

I had to downgrade this to a warning, to not break existing code.

@kba kba merged commit 1476d95 into master Sep 11, 2023
@kba kba deleted the warn-empty-page branch September 11, 2023 12:43
@MehmedGIT MehmedGIT mentioned this pull request Sep 26, 2023
Closed
@kba kba mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MehmedGIT MehmedGIT MehmedGIT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a warning if --page-id evaluates to an empty set
2 participants
@kba @MehmedGIT