Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAPI-282 Use new pcode length conversion #63

Merged
merged 2 commits into from
Nov 7, 2023
Merged

HAPI-282 Use new pcode length conversion #63

merged 2 commits into from
Nov 7, 2023

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Nov 6, 2023 •
edited
Loading

  • Use better pcode length conversion from HDX Python Country
  • Add food security NGA
  • When phase population is 0, set population_fraction_in_phase to 0.0

@mcarans mcarans requested a review from b-j-mills November 6, 2023 22:02
@mcarans mcarans changed the title HAPI 282 Use new pcode length conversion HAPI-282 Use new pcode length conversion Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023 •
edited
Loading

Test Results

4 tests  ±0   4 ✔️ ±0   4m 16s ⏱️ + 1m 45s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 46d9f9e. ± Comparison against base commit ace7f28.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Nov 6, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 6777419169

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.458%
Totals Coverage Status
Change from base Build 6777160375: 0.03%
Covered Lines: 711
Relevant Lines: 769
💛 - Coveralls

@mcarans mcarans merged commit 2625f15 into main Nov 7, 2023
3 checks passed
@turnerm turnerm deleted the admin_matching branch May 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-mills b-j-mills b-j-mills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcarans @coveralls @b-j-mills