[FIX] membership_extension: support restarted memberships #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a membership got cancelled and, later, restarted, we still had a cancellation date set, leading to the sensation that it was still cancelled.
With this refactor, when a cancellation date is earlier than a future start date, cancellation info is removed from the partner.
Before:
After:
BTW I improved a few things:
@moduon MT-8237