Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] survey_certification_sending: New module #146

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ADD] survey_certification_sending: New module #146

wants to merge 1 commit into from

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Feb 11, 2025 •
edited
Loading

@pedrobaeza pedrobaeza added this to the 15.0 milestone Feb 12, 2025
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-survey_certification_sending branch 2 times, most recently from 77be4af to 69f9f82 Compare February 12, 2025 14:14
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review February 12, 2025 14:14
chienandalu
chienandalu reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very quick review for the moment

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-survey_certification_sending branch 2 times, most recently from 9d71c63 to d4e8437 Compare February 14, 2025 17:29
chienandalu
chienandalu suggested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should avoid the download certification button. The purpose is to let the certification reviewer check the answers before sending letting the user get the certification

image

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-survey_certification_sending branch from d4e8437 to a0e5df5 Compare February 17, 2025 15:52
@pilarvargas-tecnativa
Copy link
Author

Button conditionally hidden

image

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-survey_certification_sending branch from a0e5df5 to 6ab079e Compare February 18, 2025 08:08
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-survey_certification_sending branch from 6ab079e to 50f2ed6 Compare February 21, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

@chienandalu chienandalu Awaiting requested review from chienandalu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pilarvargas-tecnativa @chienandalu @carlos-lopez-tecnativa @pedrobaeza