Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] stock_picking_group_by_max_weight: Don't recompute all pickings #1744

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[16.0][FIX] stock_picking_group_by_max_weight: Don't recompute all pickings #1744

merged 2 commits into from
Oct 15, 2024
+58 −6

Conversation

rousseldenis
Copy link
Sponsor Contributor

Improve tests and coverage too

@rousseldenis rousseldenis added this to the 16.0 milestone Oct 15, 2024
@rousseldenis
Copy link
Sponsor Contributor Author

@lmignon @phschmidt @jbaudoux

@jbaudoux
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

@jbaudoux The merge process could not start, because command `git merge --no-ff -m 'Merge PR #1744 into 16.0

Signed-off-by jbaudoux' tmp-pr-1744` failed with output:

Auto-merging stock_picking_group_by_max_weight/models/stock_picking.py
CONFLICT (content): Merge conflict in stock_picking_group_by_max_weight/models/stock_picking.py
Auto-merging stock_picking_group_by_max_weight/tests/test_group_maxweight.py
Automatic merge failed; fix conflicts and then commit the result.

@rousseldenis
[FIX] stock_picking_group_by_max_weight: Don't recompute all pickings…
5202b61 
… if changing option

As we don't want to recompute all pickings max weight, don't use the picking
type option in the depends. Moreover, don't do those writes for cancel and done pickings.
@rousseldenis
[IMP] stock_picking_group_by_max_weight: Improve tests and coverage
2d4afe2
@rousseldenis rousseldenis force-pushed the 16.0-imp-stock-picking-group-by-max-weight-dro branch from 2661c42 to 2d4afe2 Compare October 15, 2024 13:04
@rousseldenis
Copy link
Sponsor Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1744-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a2f122a into OCA:16.0 Oct 15, 2024
12 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a400ad4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
enhancement merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rousseldenis @jbaudoux @OCA-git-bot @lmignon