-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] stock_picking_return_restricted_qty: Migration to 16.0 #1642
[16.0] [MIG] stock_picking_return_restricted_qty: Migration to 16.0 #1642
Conversation
515ca15
to
abd54dc
Compare
abd54dc
to
d20fda7
Compare
d20fda7
to
8025ea3
Compare
97d2de6
to
74184ca
Compare
Hi @rousseldenis, could you please check this PR? thanks in advance! |
Techincal review OK! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test ok. It's working even if you do 2 or more returns over the same picking.
@simahawk Hi Simone! I saw you in the mainteiners list. Can you please take a look at this PR? Thanks! |
Hi @jbaudoux ! could you please check this PR? Thanks in advance! |
Hi @pedrobaeza, could you please check this PR? Thanks in advance! |
/ocabot migration stock_picking_return_restricted_qty @sergio-teruel please confirm this migration is correct. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1642-by-rousseldenis-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@ced-adhoc @sergio-teruel In fact, as this module changes the standard behavior, the restriction should be enabled through a parameter. |
@rousseldenis |
Currently translated at 100.0% (3 of 3 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_return_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_return_restricted_qty/it/
888dacb
to
bc8f950
Compare
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split the migration commit into a pure migration commit and another for the improvements?
621f2e4
to
17bd110
Compare
@jbaudoux all done! I guess |
@ced-adhoc Nearly, the changes in wizard are in the wrong commit ;) |
17bd110
to
5525f7f
Compare
@jbaudoux thanks! done |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 8a50743. Thanks a lot for contributing to OCA. ❤️ |
In this migration from v15 to v16, the following changes have been introduced:
Operation Type Configuration:
A new restrict_return_qty Boolean field has been added to stock.picking.type, allowing users to enable or disable the restriction on returning more products than delivered for each operation type.
Updated Logic for Return Picking:
The logic in stock_picking_return.py now checks the restrict_return_qty field from the related picking type. The restriction will trigger the UserError only if this setting is enabled.
Backward Compatibility:
If the setting is not enabled, the standard behavior is maintained. This behavior is widely used in purchases, where items are returned to the vendor together in one operation, regardless of the original delivery.
Steps to use: