Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] stock_push_delay #1562

Open
wants to merge 20 commits into
base: 16.0
Choose a base branch
from

Conversation

Deriman-Alonso
Copy link
Member

CLA pending for approval...

@Deriman-Alonso Deriman-Alonso mentioned this pull request Apr 9, 2024
67 tasks
@Deriman-Alonso Deriman-Alonso marked this pull request as ready for review April 9, 2024 11:12
@Deriman-Alonso Deriman-Alonso marked this pull request as draft April 9, 2024 11:17
@Deriman-Alonso Deriman-Alonso marked this pull request as ready for review April 10, 2024 07:12
@Deriman-Alonso
Copy link
Member Author

CLA pending for approval...

CLA approved.

@rousseldenis
Copy link
Contributor

/ocabot migration stock_push_delay

@rousseldenis
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

class TestPacking(TransactionCase):
@classmethod
def setUpClass(cls):
super(TestPacking, cls).setUpClass()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super(TestPacking, cls).setUpClass()
super().setUpClass()

def _push_apply(self):
"""Manual triggering"""
if self.env.context.get("manual_push", False):
new_move = super(StockMove, self)._push_apply()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new_move = super(StockMove, self)._push_apply()
new_move = super()._push_apply()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this behavior shouldn't be activated through option as this changes standard behavior.

@LoisRForgeFlow @AaronHForgeFlow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option will install the module? or maybe company specific? For me it is ok.

_inherit = "stock.picking"

def _action_done(self):
res = super(StockPicking, self)._action_done()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res = super(StockPicking, self)._action_done()
res = super()._action_done()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants