Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465

Open
wants to merge 76 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] product_cost_price_avco_sync: Migration to 16.0 #1465

wants to merge 76 commits into from

Conversation

AungKoKoLin1997
Copy link
Contributor

Standard Migration

@qrtl

@AaronHForgeFlow
Copy link
Contributor

The readme is quite short. How can I do a functional test on this module? creating a inventory adjustment on a past date? Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves?

@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Jan 4, 2024 •
edited
Loading

How can I do a functional test on this module? creating a inventory adjustment on a past date?

@AaronHForgeFlow I didn't test with inventory adjustment. For clear testing, I test with this module OCA/purchase-workflow#2137. So, we can adjust the price_unit of move from purchase order line.

Does this module provide a way to adjust layer cost upon price_unit in stock moves without creating new stock moves?

Yes, It does and also adjusts the cost of product.

@AaronHForgeFlow AaronHForgeFlow mentioned this pull request Jan 4, 2024
Merged
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review January 5, 2024 01:06
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration product_cost_price_avco_sync

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 15, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 15, 2024
Open
67 tasks
rousseldenis
rousseldenis approved these changes Jan 15, 2024
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 22b0a0c to 52228bb Compare April 10, 2024 08:41
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from 52228bb to 32f5cef Compare June 12, 2024 03:55
sergio-teruel and others added 18 commits June 12, 2024 09:28
@sergio-teruel @AungKoKoLin1997
[ADD] product_cost_price_avco_sync: New module to sync product cost w…
1fb7413 
…ith stock move price unit
@carlosdauden @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Cover more use cases
099b63e
@oca-travis @AungKoKoLin1997
[UPD] Update product_cost_price_avco_sync.pot
70d3548
@carlosdauden @AungKoKoLin1997
[MIG] product_cost_price_avco_sync: Migration to 12.0
982071a
@oca-transbot @AungKoKoLin1997
Update translation files
c5d28cc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_cost_price_avco_sync/
@carlosdauden @AungKoKoLin1997
[FIX] product_cost_price_avco_sync: Aleatory error because compare va…
67e344a 
…lue before BD write.
@OCA-git-bot @AungKoKoLin1997
product_cost_price_avco_sync 12.0.1.0.1
e73055c
@sergio-teruel @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Fix test. Aleatory error
f0ad407
@OCA-git-bot @AungKoKoLin1997
product_cost_price_avco_sync 12.0.1.0.2
83d9787
@marcelsavegnago @AungKoKoLin1997
Added translation using Weblate (Portuguese (Brazil))
ae6a179
@fcolus @AungKoKoLin1997
Translated using Weblate (Portuguese (Brazil))
047a0a6 
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_cost_price_avco_sync/pt_BR/
@carlosdauden @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Cover case if multiple move lines…
466fde6 
… with same product and distinct price are done at same second.
@OCA-git-bot @AungKoKoLin1997
product_cost_price_avco_sync 12.0.1.0.3
4a89248
@sergio-teruel @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: black, isort
7048523
@sergio-teruel @AungKoKoLin1997
[MIG] product_cost_price_avco_sync: Migration to v13.0
adaa843
@carlosdauden @AungKoKoLin1997
[MIG] product_cost_price_avco_sync: SVL compatibility
1981e3d
@carlosdauden @AungKoKoLin1997
[MIG] product_cost_price_avco_sync: Simplify code (or not)
fa11df1
@sergio-teruel @AungKoKoLin1997
[MIG] product_cost_price_avco_sync: Compute returned moves from outgo…
e2b2702 
…ing svl
carlosdauden and others added 20 commits June 12, 2024 09:28
@carlosdauden @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Use regex to extract price from d…
d463218 
…escription
@carlosdauden @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Compatibility with landed cost
c7f8c75
@pedrobaeza @AungKoKoLin1997
[FIX] product_cost_price_avco_sync: Don't fail on missing description
5e207fa
@carlosdauden @AungKoKoLin1997
Revert "[FIX] product_cost_price_avco_sync: Change Monetary fields to…
130ca46 
… Float (20,8)"

This reverts commit ace19f5
@CarlosRoca13 @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: black, isort, prettier
fed3cf0
@CarlosRoca13 @AungKoKoLin1997
[MIG] product_cost_price_avco_sync: Migration to 15.0
674bd4f
@pedrobaeza @AungKoKoLin1997
[REF] product_cost_price_avco_sync: refactor for having hooks
870faf5
@carlosdauden @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Set zero instead of insignificant…
44e7956 
… values to avoid full processing in case remaining_qty contains an insignificant value less than zero
@CarlosRoca13 @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: Add preprocess_svl_dict
533cc5d 
With this dict we are allowed to process some svls before
processing the main avoiding do writes on the method.

TT44663
@AungKoKoLin1997
[UPD] Update product_cost_price_avco_sync.pot
6bed6ab
@OCA-git-bot @AungKoKoLin1997
[UPD] README.rst
856bc77
@OCA-git-bot @AungKoKoLin1997
product_cost_price_avco_sync 15.0.1.0.1
ec00cbb
@OCA-git-bot @AungKoKoLin1997
[UPD] README.rst
e4ede57
@weblate @AungKoKoLin1997
Update translation files
3a5ad96 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/
@josep-tecnativa @AungKoKoLin1997
[IMP] product_cost_price_avco_sync: test performance improvement
d96dce4 
- Include context keys for avoiding mail operations overhead.
@OCA-git-bot @AungKoKoLin1997
[BOT] post-merge updates
5480681
@Ivorra78 @AungKoKoLin1997
Translated using Weblate (Spanish)
d9f2ff7 
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/es/
@mymage @AungKoKoLin1997
Added translation using Weblate (Italian)
c4aa1a3
@mymage @AungKoKoLin1997
Translated using Weblate (Italian)
fbe310f 
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-product_cost_price_avco_sync
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-product_cost_price_avco_sync/it/
@AungKoKoLin1997
[IMP] product_cost_price_avco_sync: pre-commit stuff
9779ee5
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch 2 times, most recently from 4f81c7b to f1525e7 Compare June 13, 2024 04:07
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2024
@AaronHForgeFlow
Copy link
Contributor

@AungKoKoLin1997 can you please rebase so runboat is rebuilt? Thanks

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-mig-product_cost_price_avco_sync branch from f1525e7 to 3033869 Compare October 14, 2024 13:30
@AungKoKoLin1997
Copy link
Contributor Author

@AaronHForgeFlow I rerun the runboat.

AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Assignees
No one assigned
Labels
approved migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.