Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] stock_picking_import_serial_number: Migration to version 15.0 #1392

Merged
merged 8 commits into from
Oct 17, 2023
Merged

[15.0][MIG] stock_picking_import_serial_number: Migration to version 15.0 #1392

merged 8 commits into from
Oct 17, 2023

Conversation

carolinafernandez-tecnativa
Copy link
Contributor

  • Standard migration to V15

@Tecnativa

TT45386

@pedrobaeza @sergio-teruel

sergio-teruel and others added 8 commits October 5, 2023 07:37
@sergio-teruel @carolinafernandez-tecnativa
[ADD] stock_picking_import_serial_number: New module
40d8b99
@sergio-teruel @carolinafernandez-tecnativa
[ADD] stock_picking_import_serial_number: New module
769e326 
[UPD] Update stock_picking_import_serial_number.pot
@pedrobaeza @carolinafernandez-tecnativa
[FIX] stock_picking_import_serial_number: Proper test helper method
07ef274 
You can't use a static assignation in kw args, and less the empty
string, which is assigned as is on the char fields (and being different
from NULL values).
@pedrobaeza @carolinafernandez-tecnativa
[FIX] stock_picking_import_serial_number: Be more resilient in tests
266cb6f 
Don't pass `default_code` in vals if no reference is provided, for
letting other modules to work properly in integration tests like
`product_code_mandatory` + `product_sequence`.
@OCA-git-bot @carolinafernandez-tecnativa
stock_picking_import_serial_number 13.0.1.0.2
7d9079b
@ryanc-me @carolinafernandez-tecnativa
[MIG] stock_picking_import_serial_number: Migration to 14.0
26e8e72
@carolinafernandez-tecnativa
[IMP] stock_picking_import_serial_number: pre-commit stuff
0b4b589
@carolinafernandez-tecnativa
[MIG] stock_picking_import_serial_number: Migration to 15.0
e72de45
@pedrobaeza
Copy link
Member

/ocabot migration stock_picking_import_serial_number

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 5, 2023
@OCA-git-bot
Copy link
Contributor

The migration issue (#913) has not been updated to reference the current pull request because a previous pull request (#1064) is not closed.
Perhaps you should check that there is no duplicate work.
CC @ryanc-me

@pedrobaeza pedrobaeza mentioned this pull request Oct 5, 2023
Closed
@pedrobaeza
Copy link
Member

/ocabot migration stock_picking_import_serial_number

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 5, 2023
Open
66 tasks
Saran440
Saran440 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carolinafernandez-tecnativa
Copy link
Contributor Author

@sergio-teruel @pedrobaeza Is it okay to move on ?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1392-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 16, 2023
@OCA-git-bot
Merge PR #1392 into 15.0
851259e 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1392-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1392-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 16, 2023
@OCA-git-bot
Merge PR #1392 into 15.0
52e31d8 
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1392-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f14c5d6 into OCA:15.0 Oct 17, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 972447d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-stock_picking_import_serial_number branch October 17, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@Saran440 Saran440 Saran440 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@carolinafernandez-tecnativa @pedrobaeza @OCA-git-bot @sergio-teruel @Saran440 @ryanc-me