[16.0][mig] stock_partner_delivery_window #1332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two small improvements: * add a hook to change the delivery time format * no need to display seconds, hh:mm is enough
…ry_time_preference The default value introduced by workdays feature breaks the installation of Demo databases as the change is not reflected in sale_partner_delivery_window.
… field is related
version conflict prevents upload to pypi
When copying partner, if the partner's delivery time preference is time window, time window ids should be copied as well.
|
/ocabot migration stock_partner_delivery_window |
nguyenminhchien
suggested changes
Sep 7, 2023
| def _get_delivery_time_format_string(self): | ||
| return _("From %s to %s") | ||
|
|
||
| def get_delivery_time_description(self): |
There was a problem hiding this comment.
@heliaktiv find no place call this method (get_delivery_time_description)
|
Because there's no feedback from the author for a long time, i created a new PR #1378 to replace this one. |
|
@heliaktiv Do you agree if we switch to #1378 ? |
|
@heliaktiv ping |
|
Enough inactivity here and we've got a completed work with reviews on #1378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.