[MIG] stock_landed_costs_currency: Migration to 16.0

[BT-jdziurzynski]

No description provided.

[BT-anieto]

Hi @BT-jdziurzynski! Thanks for your PR. Just a small comment :)

[BT-aleonard]

Hi, thanks for migrating.
The only thing I would add is to add yourself as a contributor.

[rousseldenis]

/ocabot migration stock_landed_costs_currency

[BT-jdziurzynski]

Hey @rousseldenis, I don't understand why codecov check is reduced and not passing after I added myself as a contributor. Could you take a look at this?

[rousseldenis]

Hey @rousseldenis, I don't understand why codecov check is reduced and not passing after I added myself as a contributor. Could you take a look at this?

@BT-jdziurzynski You can always inspect the lines that are missing in tests if you go to the 'Files changed' tab here.

So, adding a test that cover that line should greenify coverage.

For contributor problem, I don't get what you mean.

[BT-jdziurzynski]

Hey @rousseldenis, I don't understand why codecov check is reduced and not passing after I added myself as a contributor. Could you take a look at this?

@BT-jdziurzynski You can always inspect the lines that are missing in tests if you go to the 'Files changed' tab here.

So, adding a test that cover that line should greenify coverage.

For contributor problem, I don't get what you mean.

I already extended the tests to cover these lines and codecov was satisfied. This changed after I added myself as a contributor.

[rousseldenis]

Hey @rousseldenis, I don't understand why codecov check is reduced and not passing after I added myself as a contributor. Could you take a look at this?

@BT-jdziurzynski You can always inspect the lines that are missing in tests if you go to the 'Files changed' tab here.

So, adding a test that cover that line should greenify coverage.
For contributor problem, I don't get what you mean.

I already extended the tests to cover these lines and codecov was satisfied. This changed after I added myself as a contributor.

@BT-jdziurzynski Apparently not as this is the result for last build

[BT-anieto]

Hello @rousseldenis Tests are passing right now. Could it be that the needs_review tag is preventing the PR to be merged?
Shall anything else be done here? Thank you very much!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[rousseldenis]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1327-by-rousseldenis-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 6bbc37a. Thanks a lot for contributing to OCA. ❤️