Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_valuation_layer_usage: Migration to 16.0 #1326

Merged
merged 13 commits into from
Sep 21, 2023
Merged

[16.0][MIG] stock_valuation_layer_usage: Migration to 16.0 #1326

merged 13 commits into from
Sep 21, 2023

Conversation

EvaSForgeFlow
Copy link
Contributor

Depends on: #1323

@rousseldenis
Copy link
Contributor

/ocabot migration stock_valuation_layer_usage

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 7, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 7, 2023
Open
67 tasks
@rousseldenis
Copy link
Contributor

@EvaSForgeFlow Thanks for this. You can also embed your dependency here to make tests running and having a runboat instance for functional testing.

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@EvaSForgeFlow EvaSForgeFlow force-pushed the 16.0-mig-stock_valuation_layer_usage branch 2 times, most recently from 989dd3c to ecf6474 Compare July 12, 2023 13:50
DavidJForgeFlow
DavidJForgeFlow approved these changes Jul 13, 2023
View reviewed changes
Copy link

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rousseldenis
rousseldenis approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1326-by-JordiBForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 14, 2023
@OCA-git-bot
Merge PR #1326 into 16.0
c7f93f2 
Signed-off-by JordiBForgeFlow
@OCA-git-bot
Copy link
Contributor

@JordiBForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1326-by-JordiBForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Contributor

@JordiBForgeFlow Some dependencies are not yet merged

@rousseldenis
Copy link
Contributor

@EvaSForgeFlow Could you remove the test-requirements commit as #1323 is merged ?

JordiBForgeFlow and others added 11 commits September 21, 2023 16:58
@JordiBForgeFlow
[13.0][add] stock_valuation_layer_usage, stock_account_product_run_fi…
d6bfcd8 
…fo_hook
@oca-travis @JordiBForgeFlow
[UPD] Update stock_valuation_layer_usage.pot
9b0040f
@OCA-git-bot @JordiBForgeFlow
[ADD] icon.png
d04ae87
@AaronHForgeFlow @JordiBForgeFlow
[13.0][IMP] stock_valuation_layer_usage: change output layer selectio…
8d8d857 
…n to respect mto case
@OCA-git-bot @JordiBForgeFlow
[UPD] README.rst
fd5c5ab
@OCA-git-bot @JordiBForgeFlow
stock_valuation_layer_usage 13.0.1.1.0
eb2b8f8
@ChrisOForgeFlow @JordiBForgeFlow
[IMP] stock_valuation_layer_usage: black, isort, prettier
6cb506a
@ChrisOForgeFlow @JordiBForgeFlow
[14.0][MIG] stock_valuation_layer_usage and stock_account_product_run…
c5615bc 
…_fifo_hook
@JordiBForgeFlow
[FIX][stock_valuation_layer_usage]: look for true incoming moves
0a972d7 
In case that the out move is connected with an internal transfer,
no valuation layer will be found, and then the system will create
a layer with negative quantity. We should try to look for the
true incoming move, if there is any.
@AaronHForgeFlow @JordiBForgeFlow
[IMP] add some ux improvements
548de8b
@MiquelRForgeFlow @JordiBForgeFlow
[MIG] stock_valuation_layer_usage: Migration to 15.0
c9fb850
@JordiBForgeFlow JordiBForgeFlow force-pushed the 16.0-mig-stock_valuation_layer_usage branch from ecf6474 to 6b01828 Compare September 21, 2023 14:58
@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1326-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 49854f3 into OCA:16.0 Sep 21, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 438a6e6. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
9 participants
@EvaSForgeFlow @rousseldenis @JordiBForgeFlow @OCA-git-bot @DavidJForgeFlow @oca-travis @AaronHForgeFlow @ChrisOForgeFlow @MiquelRForgeFlow