[16.0][MIG] stock_picking_line_sequence #1316

bosd · 2023-06-23T17:16:51Z

Standard migration
stock_picking_line_sequence

rousseldenis · 2023-07-07T07:22:23Z

/ocabot migration stock_picking_line_sequence

rousseldenis

Code review

AungKoKoLin1997

The function is not working as expected.
When we create transfer and then add new product line, the sequence is 1 for first line. But after clicked save button, it changes to 2.

This is before we save.

This is after we saved.

stock_picking_line_sequence/models/stock.py

bosd · 2023-09-29T07:10:46Z

Can we get a merge? 🙏

rousseldenis · 2023-09-29T07:20:12Z

@bosd Could you amend your last commit message to add the module name and a better summary ?

Thanks

bosd · 2023-10-02T16:39:58Z

tests are broken. It seems we need this now.
#1329

bosd · 2023-10-03T05:34:42Z

/ocabot rebase

OCA-git-bot · 2023-10-03T05:34:52Z

Sorry @bosd you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Currently translated at 100.0% (7 of 7 strings) Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/sl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_picking_line_sequence/

Currently translated at 28.5% (2 of 7 strings) Translation: stock-logistics-workflow-15.0/stock-logistics-workflow-15.0-stock_picking_line_sequence Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-15-0/stock-logistics-workflow-15-0-stock_picking_line_sequence/it/

only update the sequence number when the line number is an integer.

OCA-git-bot · 2023-10-09T16:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AungKoKoLin1997 · 2023-10-13T07:19:36Z

@rousseldenis Can we get this PR merged?

rousseldenis · 2023-10-13T07:24:06Z

stock_picking_line_sequence/models/stock.py

-                line.sequence = current_sequence
-                current_sequence += 1
+                # Check if the record ID is an integer (real ID) or a string (virtual ID)
+                if isinstance(line.id, int):


@bosd FYI, usually, we use NewId class instead.

So:

if not isinstance(line.id, NewId):

rousseldenis · 2023-10-13T07:24:32Z

/ocabot merge nobump

OCA-git-bot · 2023-10-13T07:24:40Z

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1316-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-13T07:33:36Z

Congratulations, your PR was merged at ef182a3. Thanks a lot for contributing to OCA. ❤️

bosd · 2023-10-13T07:58:14Z

@CasVissers-360ERP It's merged 😉

bosd changed the title ~~16.0 mig stock picking line sequence~~ [16.0][MIG] stock_picking_line_sequence Jun 23, 2023

bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch from 84f8f16 to 7a88b45 Compare June 23, 2023 17:43

bosd marked this pull request as ready for review June 23, 2023 17:48

OCA-git-bot added this to the 16.0 milestone Jul 7, 2023

rousseldenis added needs review migration labels Jul 7, 2023

OCA-git-bot mentioned this pull request Jul 7, 2023

Migration to version 16.0 #1101

Open

67 tasks

rousseldenis approved these changes Jul 7, 2023

View reviewed changes

AungKoKoLin1997 mentioned this pull request Aug 1, 2023

[16.0][MIG] purchase_order_line_sequence: Migration to 16.0 OCA/purchase-workflow#1961

Open

AungKoKoLin1997 reviewed Aug 2, 2023

View reviewed changes

AungKoKoLin1997 reviewed Aug 10, 2023

View reviewed changes

stock_picking_line_sequence/models/stock.py Outdated Show resolved Hide resolved

bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch from 28a8d75 to 4f9b3ed Compare September 23, 2023 15:32

bosd requested a review from AungKoKoLin1997 September 23, 2023 15:41

AungKoKoLin1997 approved these changes Sep 25, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 25, 2023

bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch 2 times, most recently from e26905c to a3c7969 Compare October 2, 2023 16:27

serpentcs-dev1 and others added 7 commits October 7, 2023 14:05

[REM] redundant code

80b7180

[MIG] stock_picking_line_sequence v10

8f53bc8

[IMP] docstring

dbb2b37

OCA Transbot updated translations from Transifex

cd19a14

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[UPD] Update stock_picking_line_sequence.pot

877e762

[10.0][FIX] stock_picking_line_sequence module

4ee8f7e

[MIG] stock_picking_line_sequence migrated to version 12.0

06296c8

sysadminmatmoz and others added 16 commits October 7, 2023 14:05

[IMP] stock_picking_line_sequence: black, isort, prettier

c250547

[MIG] stock_picking_line_sequence: Migration to 14.0

b27eb57

[UPD] Update stock_picking_line_sequence.pot

b66d770

[UPD] README.rst

a6e6cf1

[UPD] contributors: Eficent -> ForgeFlow

4951fc8

[UPD] README.rst

4b834c8

[IMP] stock_picking_line_sequence: black, isort, prettier

a93a8ab

[MIG] stock_picking_line_sequence: Migration to 15.0

c84ecdb

[UPD] Update stock_picking_line_sequence.pot

f0d5b83

[UPD] README.rst

722bef6

[IMP] stock_picking_line_sequence: pre-commit execution

b426169

[MIG] stock_picking_line_sequence: Migration to 16.0

f5ae154

[FIX] stock_picking_line_sequence: sequence number

38e8e2a

only update the sequence number when the line number is an integer.

bosd force-pushed the 16.0-mig-stock_picking_line_sequence branch from c306147 to 38e8e2a Compare October 7, 2023 12:05

OCA-git-bot added the ready to merge label Oct 9, 2023

rousseldenis reviewed Oct 13, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Oct 13, 2023

OCA-git-bot merged commit 0cf2b42 into OCA:16.0 Oct 13, 2023
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 13, 2023

bosd deleted the 16.0-mig-stock_picking_line_sequence branch October 17, 2023 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] stock_picking_line_sequence #1316

[16.0][MIG] stock_picking_line_sequence #1316

bosd commented Jun 23, 2023 •

edited

Loading

rousseldenis commented Jul 7, 2023

rousseldenis left a comment

AungKoKoLin1997 left a comment •

edited

Loading

bosd commented Sep 29, 2023

rousseldenis commented Sep 29, 2023

bosd commented Oct 2, 2023

bosd commented Oct 3, 2023

OCA-git-bot commented Oct 3, 2023

OCA-git-bot commented Oct 9, 2023

AungKoKoLin1997 commented Oct 13, 2023

rousseldenis Oct 13, 2023

rousseldenis commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

bosd commented Oct 13, 2023

[16.0][MIG] stock_picking_line_sequence #1316

[16.0][MIG] stock_picking_line_sequence #1316

Conversation

bosd commented Jun 23, 2023 • edited Loading

rousseldenis commented Jul 7, 2023

rousseldenis left a comment

Choose a reason for hiding this comment

AungKoKoLin1997 left a comment • edited Loading

Choose a reason for hiding this comment

bosd commented Sep 29, 2023

rousseldenis commented Sep 29, 2023

bosd commented Oct 2, 2023

bosd commented Oct 3, 2023

OCA-git-bot commented Oct 3, 2023

OCA-git-bot commented Oct 9, 2023

AungKoKoLin1997 commented Oct 13, 2023

rousseldenis Oct 13, 2023

Choose a reason for hiding this comment

rousseldenis commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

bosd commented Oct 13, 2023

bosd commented Jun 23, 2023 •

edited

Loading

AungKoKoLin1997 left a comment •

edited

Loading