Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG]stock_lot_scrap: Migration to 15.0 #1193

Closed

Conversation

bizzappdev
Copy link
Contributor

No description provided.

carlosdauden and others added 28 commits January 18, 2023 14:20
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_lot_scrap
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_lot_scrap/pt_BR/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-stock_lot_scrap
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-stock_lot_scrap/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_lot_scrap
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_lot_scrap/
If a scrap has no lot, the action will fail as message_post ensures that
at least one record is provided.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-13.0/stock-logistics-workflow-13.0-stock_lot_scrap
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-13-0/stock-logistics-workflow-13-0-stock_lot_scrap/
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 21, 2023
@pedrobaeza pedrobaeza changed the title [WIP][15.0][MIG]stock_lot_scrap: Migration to 15.0 [15.0][MIG]stock_lot_scrap: Migration to 15.0 May 21, 2023
@bizzappdev bizzappdev force-pushed the 15.0-mig-stock-lot-scrap-BAD-SIP branch from 63f1eb2 to 116fa96 Compare May 22, 2023 05:30
@pedrobaeza
Copy link
Member

/ocabot migration stock_lot_scrap

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

self._prepare_scrap_vals(quant, scrap_location_id),
)
scraps |= scrap
result = self.env.ref("stock.action_stock_scrap").read()[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result = self.env.ref("stock.action_stock_scrap").read()[0]
result = self.env["ir.actions.act_window"]._for_xml_id("stock.action_stock_scrap")

)
.id
)
for quant in quants:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this in order to use multi create.

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1193-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 22, 2023
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot added this to the 15.0 milestone May 22, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 22, 2023
66 tasks
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1193-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Cancelled due to Denis' comments

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 28, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023
@github-actions github-actions bot closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.