Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] stock_picking_batch_extended_account_sale_type: Migration to version 15.0 #1157

Merged
merged 4 commits into from
Dec 15, 2022
Merged

[15.0][MIG] stock_picking_batch_extended_account_sale_type: Migration to version 15.0 #1157

merged 4 commits into from
Dec 15, 2022

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Dec 13, 2022 •
edited
Loading

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_picking_batch_extended_account_sale_type branch from 50491f7 to 1721313 Compare December 13, 2022 20:57
@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_batch_extended_account_sale_type

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 14, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 14, 2022
Open
66 tasks
rousseldenis
rousseldenis approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Minor change

stock_picking_batch_extended_account_sale_type/models/stock_batch_picking.py Outdated
_inherit = "stock.picking.batch"

def _get_domain_picking_to_invoice(self):
domain = super(StockBatchPicking, self)._get_domain_picking_to_invoice()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
domain = super(StockBatchPicking, self)._get_domain_picking_to_invoice()
domain = super()._get_domain_picking_to_invoice()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Done!!

@rousseldenis
Copy link
Contributor

@sergio-teruel To help reviewers test with runboat, you can include your dependency in test-requirements.txt file (in a separate commit)

@sergio-teruel
Copy link
Contributor Author

Hi @rousseldenis How can I do it? Thanks

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_picking_batch_extended_account_sale_type branch 2 times, most recently from 60cf3a1 to 8e64d6c Compare December 14, 2022 15:24
@rousseldenis
Copy link
Contributor

Hi @rousseldenis How can I do it? Thanks

It follows pip requirements format.

You can check this one for example:

OCA/product-attribute@14fada9

For instance, it is composed by :

<odoo module package name> @ git+https://github.com/OCA/<github repository>/refs/pull/<PR number>/head#subdirectory=setup/<module name>

@sergio-teruel
Copy link
Contributor Author

@rousseldenis Thanks for the info!! great!! in next PR I will try this... 👍

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-stock_picking_batch_extended_account_sale_type branch from 8e64d6c to 69d3d6d Compare December 15, 2022 08:16
@sergio-teruel
Copy link
Contributor Author

Rebase done!!

CarlosRoca13
CarlosRoca13 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1157-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 89f11e6 into OCA:15.0 Dec 15, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b57f1cf. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-mig-stock_picking_batch_extended_account_sale_type branch December 15, 2022 16:47
@pedrobaeza
Copy link
Member

I have created this wiki entry to reflect about how to do this:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s)

Please do any comment you think to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sergio-teruel @rousseldenis @pedrobaeza @OCA-git-bot @CarlosRoca13