Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15.0 mig stock partner delivery window #1146

Closed
wants to merge 23 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2022

minor changes -> had some trouble with the linter -> feedback welcome on how to do this in a more propper way

grindtildeath and others added 23 commits December 1, 2022 17:08
Two small improvements:

* add a hook to change the delivery time format
* no need to display seconds, hh:mm is enough
…ry_time_preference

The default value introduced by workdays feature breaks the installation
of Demo databases as the change is not reflected in sale_partner_delivery_window.
version conflict prevents upload to pypi
When copying partner, if the partner's delivery time preference is time
window, time window ids should be copied as well.
@ghost
Copy link
Author

ghost commented Dec 18, 2022

Could anybody review my migration?

@rousseldenis
Copy link
Contributor

/ocabot migration stock_partner_delivery_window

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 19, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 19, 2022
66 tasks
@rousseldenis
Copy link
Contributor

@nikolausweingartmair As partner_tz module is currently a PR and not merged yet, you can add a commit with a test-requirements.txt file in order to be able to test this.

You can read this to help you achieving it:

https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 23, 2023
@github-actions github-actions bot closed this May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants