Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [ADD] stock receipt lot info #1113

Merged
merged 3 commits into from
Nov 22, 2022
Merged

[16.0] [ADD] stock receipt lot info #1113

merged 3 commits into from
Nov 22, 2022

Conversation

MarcBForgeFlow
Copy link
Contributor

@MarcBForgeFlow MarcBForgeFlow commented Oct 25, 2022 •
edited
Loading

Migration based on #982.

Description

This module allows to encode more information to create lot/serial numbers
while processing an incoming shipment.

By default, you can only provide a lot/serial number name
when receiving products tracked by lot/serial numbers, with this module you can also
provide the following information of the lot:

  • Lot/Serial Expiration Date.
  • Lot/Serial Best before Date.
  • Lot/Serial Removal Date.
  • Lot/Serial Alert Date.

To do list:

@LoisRForgeFlow

@MarcBForgeFlow MarcBForgeFlow force-pushed the 16.0-mig-stock_receipt_lot_info branch 2 times, most recently from b89d9a8 to a13d32e Compare October 26, 2022 10:57
@rousseldenis
Copy link
Contributor

/ocabot migration stock_receipt_lot_info

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 26, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 26, 2022
Open
67 tasks
@LoisRForgeFlow
Copy link
Contributor

@MarcBForgeFlow Please, preserve commit history as it was being done in https://github.com/OCA/stock-logistics-workflow/pull/982/commits.

LoisRForgeFlow
LoisRForgeFlow reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment to make the test a bit more "realistic"

stock_receipt_lot_info/tests/test_receipt_lot_info.py Outdated Show resolved Hide resolved
stock_receipt_lot_info/tests/test_receipt_lot_info.py Outdated Show resolved Hide resolved
@MarcBForgeFlow MarcBForgeFlow force-pushed the 16.0-mig-stock_receipt_lot_info branch 2 times, most recently from 68c109d to 83f4e79 Compare November 16, 2022 17:15
@LoisRForgeFlow
Copy link
Contributor

@MarcBForgeFlow seems that the test failed in CI, could you have a look?

LoisRForgeFlow
LoisRForgeFlow approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

AaronHForgeFlow
AaronHForgeFlow approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1113-by-LoisRForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 22, 2022
@OCA-git-bot
Merge PR #1113 into 16.0
6ffcc14 
Signed-off-by LoisRForgeFlow
@OCA-git-bot
Copy link
Contributor

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1113-by-LoisRForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Nov 22, 2022 •
edited
Loading

Ci issue fixed in #1136.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1113-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d5adb60 into OCA:16.0 Nov 22, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1d13c5e. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 16.0-mig-stock_receipt_lot_info branch November 22, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcBForgeFlow @rousseldenis @LoisRForgeFlow @OCA-git-bot @AaronHForgeFlow