Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] product_supplierinfo_for_customer_picking #1021

Merged
merged 19 commits into from
Oct 10, 2023
Merged

[15.0][MIG] product_supplierinfo_for_customer_picking #1021

merged 19 commits into from
Oct 10, 2023

Conversation

JuanyDForgeflow
Copy link

@JuanyDForgeflow JuanyDForgeflow commented Jun 13, 2022 •
edited
Loading

Based on product_supplierinfo_for_customer, this module loads in every Stock move the
customer code defined in the product.

@JuanyDForgeflow JuanyDForgeflow changed the title [15.0][M product supplierinfo for customer picking [15.0][MIG] product_supplierinfo_for_customer_picking Jun 13, 2022
@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-product_supplierinfo_for_customer_picking branch from 4972a0c to ef5ecb5 Compare June 13, 2022 21:34
@rousseldenis
Copy link
Contributor

/ocabot migration product_supplierinfo_for_customer_picking

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 14, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2022
Open
66 tasks
@rousseldenis
Copy link
Contributor

@JuanyDForgeflow Could you fix tests ? Thanks

@lfreeke
Copy link

lfreeke commented Jul 8, 2022

When I have more than one customer in the supplier info customer list
image

The Customer Product Code from the first customer is set on the the stock move and not the Customer Product Code from the customer you have selected in the Sale Order.

Sale Order:
image

Stock Move:

image

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 10, 2022
Closed
@rousseldenis
Copy link
Contributor

@JuanyDForgeflow Could you please ping author of #1016 in order to supersedes ?

@JuanyDForgeflow
Copy link
Author

@rousseldenis If the other pr is already working I think It's best we close this one, what do you think?

@rousseldenis
Copy link
Contributor

@rousseldenis If the other pr is already working I think It's best we close this one, what do you think?

@JuanyDForgeflow I think we can close the other as no answer and owner has no github activity

@rousseldenis
Copy link
Contributor

@JuanyDForgeflow Could you look at #1016 on migration commit ? I think there are clues to fix tests. Thanks

@JuanyDForgeflow JuanyDForgeflow force-pushed the 15.0-mig-product_supplierinfo_for_customer_picking branch 4 times, most recently from 9b0f503 to bf62579 Compare February 10, 2023 17:46
@AaronHForgeFlow AaronHForgeFlow force-pushed the 15.0-mig-product_supplierinfo_for_customer_picking branch from bf62579 to 03ec2e3 Compare June 7, 2023 13:52
AaronHForgeFlow and others added 9 commits October 6, 2023 09:23
@AaronHForgeFlow @JasminSForgeFlow
[UPT] rename module and minor fixes
72a77ef
@MiquelRForgeFlow @JasminSForgeFlow
[ADD] Tests
c0fd154
@oca-travis @JasminSForgeFlow
[UPD] Update product_supplierinfo_for_customer_picking.pot
fbaa1ab
@OCA-git-bot @JasminSForgeFlow
[ADD] icon.png
353005b
@MiquelRForgeFlow @JasminSForgeFlow
[MIG] product_supplierinfo_for_customer_picking: Migration to 12.0
bd504b2
@marcelsavegnago @JasminSForgeFlow
Added translation using Weblate (Portuguese (Brazil))
781abc2
@fcolus @JasminSForgeFlow
Translated using Weblate (Portuguese (Brazil))
e63cb45 
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_supplierinfo_for_customer_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_supplierinfo_for_customer_picking/pt_BR/
@tafaRU @JasminSForgeFlow
[IMP] product_supplierinfo_for_customer_picking: black, isort, prettier
ab64230
@tafaRU @JasminSForgeFlow
[MIG] product_supplierinfo_for_customer_picking: Migration to 14.0
34bd5d6
@JasminSForgeFlow JasminSForgeFlow force-pushed the 15.0-mig-product_supplierinfo_for_customer_picking branch from 03ec2e3 to 0560afc Compare October 6, 2023 05:05
AaronHForgeFlow
AaronHForgeFlow approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, with several customers on the same product

@AaronHForgeFlow
Copy link
Contributor

@lfreeke the commented issue is now fixed. I wonder if you can help here with a new review.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1021-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4f90cae into OCA:15.0 Oct 10, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c300dda. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 15.0-mig-product_supplierinfo_for_customer_picking branch October 10, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow left review comments

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@JasminSForgeFlow JasminSForgeFlow JasminSForgeFlow approved these changes

Assignees
No one assigned
Labels
approved duplicate merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.