[17.0] mail_debrand - Button to view the quotation broken in debranded mail

[MSokol00]

Module

mail_debrand

Describe the bug

When the module is installed, it correctly removes 'Powered by Odoo' from email, but the button to open the link is cleared out as well.

To Reproduce

Affected versions: 17.0

Steps to reproduce the behavior:

1. Install module
2. Send email with quotation.

Expected behavior
The button at the top of the email should work and direct user to quotation

Additional context

[Bart-dh]

Hi @MSokol00

Does your database url contain odoo.com? I feel like the way this module is implemented, this breaks a lot of this. It is way too harsh. It also completely breaks the Digest email which obviously contains Odoo branding.

[MSokol00]

Hi @Bart-dh,

yes, that's correct. My organization is hosting a projects on odoo.sh with odoo.com domains for a couple of customers. This module basically gets rid of every html tag with '*.odoo.com' link inside, which is not the best idea.

[JochenVanSeveren]

Oh wow I just came to make an issue about mail_debrand because I faced the same issue on all of my outgoing emails.

⚠️ This really should be put in a big banner on the module itself ⚠️

social/mail_debrand/models/mail_render_mixin.py

Line 31 in c7da735

has_odoo_link = re.search(r"<a\s(.*)odoo\.com", value, flags=re.IGNORECASE)

[BurkhalterY]

Hi,
This was already fixed in 16.0 (#1181), but not forwarded.
I just made a PR here: #1595