-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] sale_rental: Migration to 16.0 #3366
base: 16.0
Are you sure you want to change the base?
Conversation
…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".
…he module description.
Add POT file Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental Add pt_BR translation, contributed by Caio Barros.
…g because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)
…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.
…a link to the screencast in the module description
…y of the rental features
Update POT file and FR translation Fix translated string in code Slovene translations added OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex remove obsolete .pot files [ci skip] fix invalid pt_BR.po Update sale_rental.pot Translated using Weblate (Nederlands (nl_NL)) Currently translated at 100,0% (99 of 99 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_rental/nl_NL/ Update sale_rental.pot Update translation files Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate. Translated using Weblate (German) Currently translated at 28.3% (28 of 99 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_rental/de/ [REM] Translation file for error
Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field
Replace openerp by odoo in import declarations
Convert readme to new subdir format
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 60.1% (62 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 100.0% (103 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/
Currently translated at 100.0% (104 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/
Currently translated at 55.7% (58 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/it/
Currently translated at 100.0% (104 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Currently translated at 100.0% (104 of 104 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/es/
Anyone can help getting this out?, need reviewers though , only did some minor modifications, nothing complicated @pedrobaeza @yvaucher @alexis-via @sbidoul |
Sorry, not using it. Maybe @alexis-via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. LGTM
This was suggested to be moved to OCA/vertical-rental here #2325 You can find and review the PR OCA/vertical-rental#46 to move forward. |
I dont think that is logical given, that this module is not a standalone
app, not solves rental in a generic way, and that repo is for a vertical,
this module really doesnt fit in there IMHO, is much more limited in scope,
a mere extension to sale.order
Saludos,
--------------------------------------------
Ignacio J.Ortega
skype:ignacioj.ortega
El mié, 27 nov 2024 a las 12:07, ChristianRB ***@***.***>)
escribió:
… This was suggested to be moved to OCA/vertical-rental here #2325
<#2325> You can find and review
the PR OCA/vertical-rental#46
<OCA/vertical-rental#46> to move forward.
—
Reply to this email directly, view it on GitHub
<#3366 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHYV47ZIU4XOSUGHLQTID2CWRWDAVCNFSM6AAAAABQGKET7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBTGU4DONJSGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
/ocabot migration sale_rental |
@rousseldenis This seems to be wip here OCA/vertical-rental#46 |
No description provided.