Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] base_report_to_printer_mail: Migration to 16.0 #333

Merged

Conversation

QuocDuong1306
Copy link

Depend on #332

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-base_report_to_printer_mail branch from 6267fdd to 68f96ba Compare July 14, 2023 03:52
Copy link

@BT-anieto BT-anieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You would need to squash the commits as indicated in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-base_report_to_printer_mail branch from 68f96ba to ace74b7 Compare August 2, 2023 07:28
@QuocDuong1306
Copy link
Author

Hi @BT-anieto , I updated

@@ -0,0 +1 @@
../../../../base_report_to_printer_mail
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change related to setup folder are also normally part of the [IMP] $module: pre-commit stuff if you follow the OCA migration guidelines: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#technical-method-to-migrate-a-module-from-150-to-160-branch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your review, I updated

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-base_report_to_printer_mail branch from ace74b7 to 2258631 Compare September 11, 2023 13:30
@sebalix
Copy link
Contributor

sebalix commented Sep 12, 2023

@QuocDuong1306 thank you!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-333-by-sebalix-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 12, 2023
Signed-off-by sebalix
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 14, 2024
@sebalix
Copy link
Contributor

sebalix commented Jan 17, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-333-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d6ec67 into OCA:16.0 Jan 17, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5034bed. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants