[16.0][MIG] pingen: Migration to 16.0 #315

ajaniszewska-dev · 2023-01-26T12:00:49Z

includes changes from: https://github.com/OCA/report-print-send/pull/290/files

pingen/migrations/10.0.2.0.0/pre-migration.py

pingen/models/pingen_document.py

grindtildeath · 2023-05-02T14:49:41Z

pingen/README.rst

+A second cron updates the informations of the documents from pingen.com, so we
+know which of them have been sent.


This is now managed through webhooks calls from pingen, can you please update?

grindtildeath · 2023-05-02T14:50:17Z

pingen/README.rst

+The authentication token is configured on the company's view. You can also
+tick a checkbox if the staging environment (https://stage-api.pingen.com)
+should be used.
+
+The setup of the 2 crons can be changed as well:
+
+ * Run Pingen Document Push
+ * Run Pingen Document Update


Can you please update this part as well? Explaining how to configure the webhooks and so on?

@grindtildeath updated

pingen/__manifest__.py

pingen/readme/CONTRIBUTORS.rst

simahawk

LG overall. Can you please squash commits?

pingen/controllers/main.py

simahawk · 2023-10-09T14:21:41Z

pingen/models/res_company.py

+            staging=self.pingen_staging,
+        )
+
+    def _get_pingen_client(self):


isn't this redundant?

i dont see why?

because you return the same result of _pingen?

@ajaniszewska-dev
We could keep only _get_pingen_client and remove the extra call to _pingen. Not blocking though

pingen/tests/__init__.py

pingen/__init__.py

simahawk · 2023-10-11T11:40:30Z

@grindtildeath ping

grindtildeath

Few more things to clean up

grindtildeath · 2023-10-11T14:09:11Z

pingen/models/res_company.py

+            staging=self.pingen_staging,
+        )
+
+    def _get_pingen_client(self):


@ajaniszewska-dev
We could keep only _get_pingen_client and remove the extra call to _pingen. Not blocking though

grindtildeath · 2023-10-11T14:10:24Z

pingen/models/pingen.py

+            letter_id=document_uuid,
+        )
+        return response.json().get("data", {}).get("attributes")
+        # return response.json()['item']


grindtildeath · 2023-10-11T14:10:35Z

pingen/models/pingen.py

+        # if rjson.get('send'):
+        #     # confusing name but send_id is the posted id
+        #     posted_id = rjson['send'][0]['send_id']
+        # item = rjson['item']


grindtildeath · 2023-10-11T14:11:15Z

pingen/models/pingen.py

+        # we cannot use the `files` param alongside
+        # with the `datas`param when data is a
+        # JSON-encoded data. We have to construct
+        # the entire body and send it to `data`
+        # https://github.com/kennethreitz/requests/issues/950
+        # formdata = {
+        #     'file': (filename, filestream.read()),
+        # }


grindtildeath · 2023-10-11T14:12:14Z

pingen/models/pingen.py

+        # file_upload = self._get_file_upload()
+
+        # multipart, content_type = encode_multipart_formdata(formdata)


grindtildeath · 2023-10-11T14:12:35Z

pingen/models/pingen.py

+            "file_original_name": filename,
+            "file_url": url,
+            "file_url_signature": url_signature,
+            # TODO Use parameters and mapping


Is this TODO still relevant?

i'd like to know it too...probably not so ill remove together will all other commented code

grindtildeath · 2023-10-11T14:14:07Z

pingen/models/ir_attachment.py

+    def _prepare_pingen_document_vals(self):
+        return {
+            "attachment_id": self.id,
+            # 'config': 'created from attachment'


grindtildeath · 2023-10-11T14:15:01Z

pingen/models/pingen.py

@@ -0,0 +1,317 @@
+# Author: Guewen Baconnier
+# Copyright 2012-2017 Camptocamp SA


Suggested change

# Copyright 2012-2017 Camptocamp SA

# Copyright 2012-2023 Camptocamp SA

I would do the same for all the other files

grindtildeath · 2023-10-11T14:15:52Z

pingen/models/pingen_document.py

+        # if post_id:
+        #     state = 'sendcenter'
+        # elif infos['requirement_failure']:
+        #     state = 'pingen_error'
+        #     error = _('The document does not meet the Pingen requirements.')


grindtildeath · 2023-10-11T14:16:59Z

pingen/data/pingen_data.xml

+
+  <record forcecreate="True" id="ir_cron_update_pingen" model="ir.cron">
+    <field name="name">Run Pingen Document Update</field>
+    <field eval="True" name="active" />


Shouldn't this one be set to False as default since the webhooks must update the document?

seems to make sense, updated

ajaniszewska-dev · 2023-11-13T09:22:07Z

@pedrobaeza any chance to merge this?

grindtildeath · 2023-11-13T10:36:57Z

pingen/models/pingen.py

+            return "https://api-staging.v2.pingen.com"
+        return "https://api.v2.pingen.com"


The urls with ".v2." will be discontinued in April 2024

as there is card for that, we will followup in another PR, so lets try to merge this one first.

pedrobaeza · 2023-11-13T11:38:19Z

Please squash commit history for avoiding useless commits like "Remove commented code" or "fix pre-commit". You are also ignoring the commit message conventions:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

Please adjust them.

Standard migration, incl. changes proposed in OCA#290 Add unit test.

ajaniszewska-dev · 2023-12-28T09:59:49Z

Please squash commit history for avoiding useless commits like "Remove commented code" or "fix pre-commit". You are also ignoring the commit message conventions:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#71commit-message

Please adjust them.

@pedrobaeza should be better. If there is still any wrong commit - please point what i missed. Thank you.

pedrobaeza · 2023-12-28T10:00:58Z

/ocabot merge nobump

OCA-git-bot · 2023-12-28T10:01:15Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-315-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-12-28T10:05:54Z

Congratulations, your PR was merged at 671f36c. Thanks a lot for contributing to OCA. ❤️

ajaniszewska-dev changed the title ~~[MIG] $MODULE: Migration to 12.0~~ [MIG] pingen Migration to 16.0 Jan 26, 2023

ajaniszewska-dev changed the title ~~[MIG] pingen Migration to 16.0~~ [MIG] pingen: Migration to 16.0 Jan 26, 2023

ajaniszewska-dev changed the title ~~[MIG] pingen: Migration to 16.0~~ [WIP][MIG] pingen: Migration to 16.0 Jan 26, 2023

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch 19 times, most recently from 68fe609 to 3e2c5f0 Compare January 31, 2023 13:08

TDu reviewed Jan 31, 2023

View reviewed changes

pingen/migrations/10.0.2.0.0/pre-migration.py Outdated Show resolved Hide resolved

sebalix added this to the 16.0 milestone Feb 1, 2023

sebalix added the migration label Feb 1, 2023

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch from b8945a1 to 515fa7c Compare February 22, 2023 08:00

ajaniszewska-dev commented Feb 22, 2023

View reviewed changes

pingen/models/pingen_document.py Outdated Show resolved Hide resolved

TDu reviewed Mar 8, 2023

View reviewed changes

pingen/models/pingen_document.py Show resolved Hide resolved

ajaniszewska-dev mentioned this pull request Apr 28, 2023

[ADD] pingen_env #327

Merged

grindtildeath reviewed May 2, 2023

View reviewed changes

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch 2 times, most recently from 3636851 to 3cc98c2 Compare October 9, 2023 13:41

grindtildeath reviewed Oct 9, 2023

View reviewed changes

pingen/__manifest__.py Outdated Show resolved Hide resolved

pingen/__manifest__.py Outdated Show resolved Hide resolved

pingen/readme/CONTRIBUTORS.rst Show resolved Hide resolved

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch from 3cc98c2 to 836c7fa Compare October 9, 2023 13:51

ajaniszewska-dev requested a review from grindtildeath October 9, 2023 13:57

simahawk reviewed Oct 9, 2023

View reviewed changes

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch 2 times, most recently from b0e5817 to 945608f Compare October 10, 2023 11:12

simahawk reviewed Oct 10, 2023

View reviewed changes

pingen/__init__.py Outdated Show resolved Hide resolved

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch from 945608f to 6d2a3ef Compare October 10, 2023 11:25

simahawk approved these changes Oct 11, 2023

View reviewed changes

grindtildeath reviewed Oct 11, 2023

View reviewed changes

grindtildeath approved these changes Oct 11, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 11, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 15, 2023

grindtildeath reviewed Nov 13, 2023

View reviewed changes

[MIG] pingen: Migration to 16.0

0d86765

Standard migration, incl. changes proposed in OCA#290 Add unit test.

ajaniszewska-dev force-pushed the 16.0-mig-pingen branch from 94da297 to 0d86765 Compare December 28, 2023 09:48

pedrobaeza changed the title ~~[MIG] pingen: Migration to 16.0~~ [16.0][MIG] pingen: Migration to 16.0 Dec 28, 2023

OCA-git-bot added the bot is merging ⏳ label Dec 28, 2023

OCA-git-bot merged commit d73e606 into OCA:16.0 Dec 28, 2023
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] pingen: Migration to 16.0 #315

[16.0][MIG] pingen: Migration to 16.0 #315

ajaniszewska-dev commented Jan 26, 2023 •

edited

Loading

grindtildeath May 2, 2023

grindtildeath May 2, 2023

ajaniszewska-dev May 3, 2023

simahawk left a comment

simahawk Oct 9, 2023

ajaniszewska-dev Oct 9, 2023

simahawk Oct 11, 2023

grindtildeath Oct 11, 2023

simahawk commented Oct 11, 2023

grindtildeath left a comment

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

ajaniszewska-dev Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

grindtildeath Oct 11, 2023

ajaniszewska-dev Oct 11, 2023

ajaniszewska-dev commented Nov 13, 2023

grindtildeath Nov 13, 2023

ajaniszewska-dev Nov 13, 2023

pedrobaeza commented Nov 13, 2023

ajaniszewska-dev commented Dec 28, 2023

pedrobaeza commented Dec 28, 2023

OCA-git-bot commented Dec 28, 2023

OCA-git-bot commented Dec 28, 2023

		A second cron updates the informations of the documents from pingen.com, so we
		know which of them have been sent.

		# file_upload = self._get_file_upload()

		# multipart, content_type = encode_multipart_formdata(formdata)

		@@ -0,0 +1,317 @@
		# Author: Guewen Baconnier
		# Copyright 2012-2017 Camptocamp SA

	# Copyright 2012-2017 Camptocamp SA
	# Copyright 2012-2023 Camptocamp SA

		return "https://api-staging.v2.pingen.com"
		return "https://api.v2.pingen.com"

[16.0][MIG] pingen: Migration to 16.0 #315

[16.0][MIG] pingen: Migration to 16.0 #315

Conversation

ajaniszewska-dev commented Jan 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk commented Oct 11, 2023

grindtildeath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ajaniszewska-dev commented Nov 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 13, 2023

ajaniszewska-dev commented Dec 28, 2023

pedrobaeza commented Dec 28, 2023

OCA-git-bot commented Dec 28, 2023

OCA-git-bot commented Dec 28, 2023

ajaniszewska-dev commented Jan 26, 2023 •

edited

Loading