Use a cron instead of threads to update printers status #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation with threads was blocking the loading of the server in multiprocess. Using a cron will lower the frequency of the updates but at least it is simple and reliable. Fixes OCA#14
Avoid unnecessary UPDATE every minute
guewen
force-pushed
the
base_report_to_printer-cron-issue14
branch
from
6db8d1b
to
2b5af7e
Compare
|
What a cleaning! Indeed, this doesn't provide real time, but it's safer and don't include possible lockings. 👍 |
|
Big code simplification ! 👍 |
lepistone
added a commit
that referenced
this pull request
Dec 17, 2014
Use a cron instead of threads to update printers status
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation with threads was blocking the loading of the server in
multiprocess. Using a cron will lower the frequency of the updates but at
least it is simple and reliable.
Fixes #14