Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] [MIG] product_configurator_sale: Migration to 18.0 #151

Open
wants to merge 90 commits into
base: 18.0
Choose a base branch
from

Conversation

bizzappdev
Copy link
Contributor

Dependency PR for module product_configurator #150

rsh-pledra and others added 30 commits February 3, 2025 11:50
…ng variant on default action_config_done method
…, added sale_management instead of sale to configurator
…: add config_session_id in place of product_tmpl_id to call method 'create_get_variant'
…urchase : add config_session_id in place of product_tmpl_id to call method 'create_get_variant'"

This reverts commit 35319829dac4ba1e61c561f5ce758e567cef090f.
…: add config_session_id in place of product_tmpl_id to call method 'create_get_variant'
…: add class fa-lg on sale_order)line and purchase_order_line
…ase,product_configurator_sale: call action_next_step to open next step directly
…t_cnofigurator_sale: remove deletion of 'view_cache'from action and change icon
…nfigurator_purchase: add generic method and call that
dannyadair and others added 20 commits February 3, 2025 11:50
Also there is no need to repeat which fields the method is depending on
Otherwise the following is raised:
in _get_order_line_vals
    "customer_lead": product.sale_delay,
AttributeError: 'product.product' object has no attribute 'sale_delay'
Currently translated at 100.0% (35 of 35 strings)

Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_sale
Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_sale/it/
Currently translated at 100.0% (35 of 35 strings)

Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_sale
Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_sale/it/
Currently translated at 100.0% (35 of 35 strings)

Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_sale
Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_sale/pt/
Currently translated at 100.0% (35 of 35 strings)

Translation: product-configurator-16.0/product-configurator-16.0-product_configurator_sale
Translate-URL: https://translation.odoo-community.org/projects/product-configurator-16-0/product-configurator-16-0-product_configurator_sale/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-configurator-17.0/product-configurator-17.0-product_configurator_sale
Translate-URL: https://translation.odoo-community.org/projects/product-configurator-17-0/product-configurator-17-0-product_configurator_sale/
@bizzappdev bizzappdev marked this pull request as ready for review February 14, 2025 08:02
<record id="sale.product_template_action" model="ir.actions.act_window">
<field
name="context"
>{&quot;search_default_filter_to_sell&quot;:1, &quot;search_default_filter_standard_products&quot;: 1, &quot;sale_multi_pricelist_product_template&quot;: 1}</field>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we don't actually need to escape quotes here 🤔
Anyway, nitpicking



class SaleOrder(TC.ProductConfiguratorTestCases):
def setUp(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setUpClass

@bizzappdev bizzappdev marked this pull request as draft February 18, 2025 05:53
@bizzappdev bizzappdev force-pushed the 18.0-mig-product_configurator_sale-BAD branch from 07e3bf7 to 8c1ec38 Compare February 19, 2025 07:43
@bizzappdev bizzappdev force-pushed the 18.0-mig-product_configurator_sale-BAD branch from 8c1ec38 to e7f0a70 Compare February 19, 2025 07:59
@bizzappdev bizzappdev marked this pull request as ready for review February 19, 2025 11:06
@bizzappdev
Copy link
Contributor Author

@ivantodorovich Thank you for the review. changes are done as requested.

@ivantodorovich
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.