[FIX] Fixing error External ID not found on country from on click button #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rousseldenis, |
Gonzo1795
approved these changes
Sep 4, 2024
simoneversienti
approved these changes
Sep 4, 2024
|
👍 |
OpenCode
approved these changes
Sep 4, 2024
acorpuz
approved these changes
Sep 4, 2024
rousseldenis
requested changes
Sep 4, 2024
| @@ -43,7 +43,7 @@ def _compute_product_country_restriction_ids(self): | |||
|
|
|||
| def action_view_country_restrictions(self): | |||
| self.ensure_one() | |||
| ref = "product_country_restriction." "product_country_restrictionact_window" | |||
| ref = "product_country_restriction." "product_country_restriction_act_window" | |||
There was a problem hiding this comment.
Suggested change
| ref = "product_country_restriction." "product_country_restriction_act_window" | |
| action_dict = self.env["ir.actions.act_window"]._for_xml_id("product_country_restriction.product_country_restriction_act_window") |
rousseldenis
approved these changes
Sep 5, 2024
|
@valentinagiuliani-rapsodoo Could you check pre-commit ? |
|
@valentinagiuliani-rapsodoo Could you merge the pre-commit commit with the preceding one? |
valentinagiuliani-rapsodoo
force-pushed
the
16.0
branch
from
7752cf6 to
78aa300
Compare
|
@valentinagiuliani-rapsodoo Last thing : could you modify your commit messages to reflect module name like |
…d in the system: product_country_restriction.product_country_restrictionact_window" on click button on country form
valentinagiuliani-rapsodoo
force-pushed
the
16.0
branch
from
78aa300 to
a4d6f81
Compare
OpenCode
approved these changes
Sep 9, 2024
rousseldenis
approved these changes
Sep 19, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 141fc99. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] Fixing error "External ID not found in the system: product_country_restriction.product_country_restrictionact_window" on click button on country form