Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] account_invoice_inter_company : partner_shipping_id shouldn't b… #652

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[16.0][FIX] account_invoice_inter_company : partner_shipping_id shouldn't b… #652

merged 1 commit into from
Aug 6, 2024

Conversation

metaminux
Copy link
Contributor

…e propagated to supplier invoices

fixes #651

@metaminux
Copy link
Contributor Author

Hi @alexis-via and @pedrobaeza,

There is no maintainer on this module. Can I have your feedback on this PR ? Thanks.

Kev-Roche
Kev-Roche approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Kev-Roche Kev-Roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jun 26, 2024
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@metaminux
Copy link
Contributor Author

Hi @alexis-via and @pedrobaeza,

Can one of you merge this approved PR ?

Regards,

@pedrobaeza pedrobaeza changed the title [FIX] account_invoice_inter_company : partner_shipping_id shouldn't b… [16.0][FIX] account_invoice_inter_company : partner_shipping_id shouldn't b… Aug 6, 2024
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-652-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cc97c0d into OCA:16.0 Aug 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9dea4b1. Thanks a lot for contributing to OCA. ❤️

@metaminux metaminux deleted the 16.0_fix_partner_shipping_id_propagation branch August 7, 2024 08:34
@Kev-Roche Kev-Roche mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@Kev-Roche Kev-Roche Kev-Roche approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@metaminux @OCA-git-bot @pedrobaeza @Kev-Roche