[16.0][IMP] mail_multicompany: search most appropriate server based on the from email #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinaAForgeFlow
force-pushed
the
16.0-imp-mail_multicompany-find_most_appropriate_server
branch
from
636faf5
to
8a970f3
Compare
|
Hi @luisg123v, |
MiquelRForgeFlow
approved these changes
Apr 24, 2024
| self.sudo().env["ir.mail_server"].search([("company_id", "=", company_id)]) | ||
| ) | ||
| if not mail_servers: | ||
| return False, email_from |
There was a problem hiding this comment.
Suggested change
| return False, email_from | |
| return None, email_from |
as the same odoo does in _find_mail_server
MarinaAForgeFlow
force-pushed
the
16.0-imp-mail_multicompany-find_most_appropriate_server
branch
from
8a970f3
to
87541e5
Compare
This commit improves the create() overwritte on the mail_message class so that the mail server selected is the most apropriate taking into account the from email, but considering only the mail servers of the current company.
MarinaAForgeFlow
force-pushed
the
16.0-imp-mail_multicompany-find_most_appropriate_server
branch
from
87541e5
to
55b5d47
Compare
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 6dd0d41. Thanks a lot for contributing to OCA. ❤️ |
MiquelRForgeFlow
deleted the
16.0-imp-mail_multicompany-find_most_appropriate_server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.