[17.0][MIG] account_invoice_inter_company #595
Conversation
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
from
e02a9f5
to
17b5222
Compare
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
from
17b5222
to
92f1a19
Compare
|
The test Although the "Common Product Catalog" feature of this module seems appealing, in order to make it work, we need to bypass the Odoo |
account_invoice_inter_company/tests/test_inter_company_invoice.py
Outdated
Show resolved
Hide resolved
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
3 times, most recently
from
0ca9b12
to
ccb595e
Compare
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
from
ccb595e
to
0b2bae4
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@cuongnmtm
|
|
/ocabot migration account_invoice_inter_company |
|
Sorry @cuongnmtm you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
pedrobaeza
removed
the
stale
|
/ocabot migration account_invoice_inter_company |
|
@pedrobaeza |
|
That PRs don't have the guarantee of having a correct CI. |
I will check it. Thanks. |
* [10.0]Migrate account_invoice_inter_company module to v10 * refactor code for play onchange method * active demo datas and fix account_invoice.py, res_config.py, README.rst file * extract the search domain of users from the _check_intercompany_product method * fix test * fix test and update french translation * rename openerp to odoo * fix test_flake8 and fix views after David's comment * add oca_dependencies.txt * fix bare except * improve action_cancel method * fix chart_template_id in tests * fix transfer_account_id in tests * fix chart_template_id for company B in tests * improve tests * fix tests taking into account the base_multi_company module * fix tests and contributors after lasley's comment * improve tests * fix account_invoice.py after mourad's comment * fix tests after lasley's comment * fix transfer account template in demo data * increases test coverage * improve action_invoice_open method after astirpe's comment * fix value for chart_template_id in tests
|
@cuongnmtm Hi, could you please rebase and squash administrative commits ? Thanks! |
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
from
0b2bae4
to
5d5fa21
Compare
This demo data is quite dangerous by design, since it creates compenies, accounts, decides the companies country, etc. All of that by hand. In a tested integration environment, this fails when installing account-related addons due to companies not having a chart of accounts. The fix is simple: remove this from demo data and leave it just as test data.
… in invoice lines (OCA#111) * Add product mapping in roadmap * Allow creation of invoice lines without products
…tax rates on sales and purchase invoices
…ale and account_invoice_start_end_dates
This commit reuses the same form for the same invoice, thus eliminating the creation overhead. It also does the same with the invoice lines, generating one and changing its values each time. This change increases the speed drastically when validating them.
We need to check the access right of the product not the line
This avoids getting a "No Chart of Account Template has been defined !" error on fresh database install
Currently translated at 100.0% (30 of 30 strings) Translation: multi-company-16.0/multi-company-16.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-account_invoice_inter_company/es/
Currently translated at 100.0% (30 of 30 strings) Translation: multi-company-16.0/multi-company-16.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-account_invoice_inter_company/es_AR/
from eligible companies in `_find_company_from_invoice_partner`
Currently translated at 36.6% (11 of 30 strings) Translation: multi-company-16.0/multi-company-16.0-account_invoice_inter_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-account_invoice_inter_company/it/
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
2 times, most recently
from
67f8aef
to
558f907
Compare
|
@carolinafernandez-tecnativa I rebased, and squashed administrative commits. |
There was a problem hiding this comment.
Functional review LGTM :) Thanks
There are still some administrative commits such as git oca bot that should be squashed.
ping @pedrobaeza
account_invoice_inter_company/tests/test_inter_company_invoice.py
Outdated
Show resolved
Hide resolved
account_invoice_inter_company/tests/test_inter_company_invoice.py
Outdated
Show resolved
Hide resolved
cuongnmtm
force-pushed
the
17.0-mig-account_invoice_inter_company
branch
from
558f907
to
de949d1
Compare
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 5e06a0f. Thanks a lot for contributing to OCA. ❤️ |
Note:
The test
test_confirm_invoice_with_product_and_shared_catalogis failed.The reason is that Odoo v17 now has a
check_company=Trueattribute on theproduct_idfield of theaccount.move.line, which was not present in v16.Although the "Common Product Catalog" feature of this module seems appealing, in order to make it work, we need to bypass the Odoo
check_companyattribute. This makes the feature less appealing and we should consider removing it from the module. Instead, users can remove the company value on some products to make them shared products, which is a normal procedure for inter-company.=> I will remove the "Common Product Catalog" option.