[FIX] account_invoice_inter_company: Move demo data to test

[yajo]

This demo data is quite dangerous by design, since it creates compenies, accounts, decides the companies country, etc. All of that by hand.

In a tested integration environment, this fails when installing account-related addons due to companies not having a chart of accounts.

The fix is simple: remove this from demo data and leave it just as test data.

@Tecnativa

[yajo]

Travis' ❌ is unrelated, and the main branch is already broken as you can see.

You can also check that this addon's tests pass fine.

[pedrobaeza]

This shouldn't be the method. You have a method try_load_chart_template or similar executed on company record for loading the proper chart template.

[yajo]

AFAICS this line can be removed, as it's not used. I don't want to refactor everything unless strictly necessary, TBH.

[pedrobaeza]

But you need to load the chart template any way. Previously they tricked the system adding as demo all the stuff that this method makes. You need also to look for demo XML-IDs used here in the test.

[yajo]

Yes, I'm just loading the XML data in the test itself. It seems a common pattern for testing when you need to lazy-load some demo data, or you need to ensure its state. This way I don't need to rewrite the tests.

You can see it works fine.

[pedrobaeza]

Well, it can cause side effects, as not all data is properly set (from the account module perspective, and this is an irregular way of having a chart of account. For example, field chart_template_id on company is not set - as there's no chart template -), so this can throw side effects, not right now, but on future changes or dependent modules.

[pedrobaeza]

I didn't have to change the approach for this, so I fast-track it (although branch is red due to other failed test), and I can, I'll do it in a new PR.