Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Make mrp_production_note installable in v9 #73

Merged
merged 1 commit into from
Jan 18, 2016
Merged

[MIG] Make mrp_production_note installable in v9 #73

merged 1 commit into from
Jan 18, 2016

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Jan 15, 2016

No description provided.

@@ -1,17 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<openerp>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use <odoo>.

@max3903 max3903 modified the milestone: 9.0 Jan 15, 2016
@max3903
Copy link
Member

max3903 commented Jan 15, 2016

@oihane In travis.yml of the repo, matrix is wrongly indented. As a consequence, the tests are not run properly. It should be at the same level as global.

Example in v8:
https://github.com/OCA/manufacture/blob/8.0/.travis.yml

Can you fix that please?

@pedrobaeza pedrobaeza mentioned this pull request Jan 15, 2016
21 tasks
@oihane oihane changed the title [MIG] Make mrp_poduction_note installable in v9 [MIG] Make mrp_production_note installable in v9 Jan 18, 2016
@oihane
Copy link
Contributor Author

oihane commented Jan 18, 2016

@pedrobaeza @max3903 there is some issue with coveralls, but module is ready for review

@max3903
Copy link
Member

max3903 commented Jan 18, 2016

@oihane There is no issue with Coveralls. It computes the code coverage difference between your branch and OCA/9.0. As there is no code coverage yet on OCA/9.0, it stays in pending state.

👍

@pedrobaeza
Copy link
Member

There were a problem in Coveralls reported by its status agent, but now is correct.

👍

pedrobaeza added a commit that referenced this pull request Jan 18, 2016
[MIG] Make mrp_production_note installable in v9
@pedrobaeza pedrobaeza merged commit 896b680 into OCA:9.0 Jan 18, 2016
@oihane oihane deleted the 9.0-note branch February 5, 2016 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants