Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] quality_control #298

Merged
merged 30 commits into from
Aug 30, 2018
Merged

[11.0][MIG] quality_control #298

merged 30 commits into from
Aug 30, 2018

Conversation

ProcessControl-JHF
Copy link

@ProcessControl-JHF ProcessControl-JHF mentioned this pull request Aug 23, 2018
Closed
25 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Aug 23, 2018
LoisRForgeFlow
LoisRForgeFlow reviewed Aug 27, 2018
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to recall two old api.one methods that weren't still adapted to handle recordsets. You fixed most of them but I believe you missed these two.

Thanks for the migration.

quality_control/models/qc_inspection.py Outdated

@api.depends('inspection_lines', 'inspection_lines.success')
def _compute_success(self):
self.success = all([x.success for x in self.inspection_lines])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapt for recordsets

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

quality_control/models/qc_inspection.py Outdated

@api.depends('object_id')
def _compute_product_id(self):
if self.object_id and self.object_id._name == 'product.product':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

LoisRForgeFlow
LoisRForgeFlow approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

oihane and others added 26 commits August 30, 2018 08:09
@oihane @pedrobaeza
Modulos de calidad sin migrar
192e8e7
@pedrobaeza
quality_control * PEP8 * Travis * Size in field (deprecated)
3b1947a
@alfredoavanzosc @pedrobaeza
no msg
4c45b09
@pedrobaeza
quality_control: Some improvement
4941eb1
@alfredoavanzosc @pedrobaeza
no msg
ceaae88
@oihane @pedrobaeza
<quality_control> deleted constraint
602e8c5
@alfredoavanzosc @pedrobaeza
no msg
45e89f3
@oihane @pedrobaeza
quality_control: * Made line tree editable on test templates
78caa2f 
* Fixing problems
@pedrobaeza
quality_control: Total refactorization with new API, README files, an…
4963f87 
…d new concepts. * Triggers for product category * ACLs * Tolerances in questions * one2many copyable * Fix some views * Error on same tolerance * Colors on inspection lines * Unify inspection header data assignment in set_test method * key name in set_test * Change icon set
@oihane @pedrobaeza
New module <quality_control_hr> closes OCA#662 * Changes in access ru…
5cd2960 
…les * Trigger line instead of test and user
@pedrobaeza
quality_control * Fix wizard set test
986bd6e 
* Expand AUTHORS

* Fix permissions
@ejans @pedrobaeza
changed default references of fields.Datetime.now() to fields.Datetim…
fe06db8 
…e.now
@sysadminmatmoz @pedrobaeza
Slovene translations added
1dd735d
@oihane @pedrobaeza
quality_control: * Changed permissions
e70d40c 
* security modified
* some demo info added
* Added "partner_selectable" field, so that inspections can by made by partner
* Little view fixing, field was oe_edit_only instead of label
* Add partners to trigger lines
* Tests added
* Trigger lines with duplicated test cleaned

quality_control: Propose to OCA

quality_control: required changes

quality_control: Fixing coveralls

quality_control_stock: * added demo data * replaced unlink method by ondelete="cascade" * required changes
@pedrobaeza
quality_control_*: Make use of qty field
dfb0f98 
Making it a regular field, you can put any manual quantity in inspections
@oihane @pedrobaeza
quality_control: deleting qc.inspection does not delete its lines fixed
8363283
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
5e92526
@pedrobaeza
[IMP] quality_control: decimal precision configurable + approving ins…
cd37357 
…pections only by quality control managers
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
876e43e
@LoisRForgeFlow @pedrobaeza
[9.0][MIG] quality_control
272b44c
@pedrobaeza
[FIX] quality_control: Several things:
1605ec2 
* not take into account inactivated tests trigger lines
* show action_cancel button in inspections even if it is autogenerated
@zamberjo @pedrobaeza
[FIX] quality_control: Fix TypeError on new test category (OCA#193)
94f513d 
`TestQualityControl` is failing on `QcTestTemplateCatergory._get_complete_name`
when `name` is set as `False`.
@LoisRForgeFlow @pedrobaeza
[9.0][FIX] quality_control: use odoo tag on views
15a1ab1
@SimoRubi @pedrobaeza
[MIG] quality_control: Migration to 10.0
069fd45
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
999b72b
@oca-travis @pedrobaeza
[UPD] Update quality_control.pot
13e323e
SimoRubi and others added 4 commits August 30, 2018 08:19
@SimoRubi @pedrobaeza
Translated using Weblate (Italian)
769c6a6 
Currently translated at 100.0% (127 of 127 strings)

Translation: manufacture-10.0/manufacture-10.0-quality_control
Translate-URL: https://translation.odoo-community.org/projects/manufacture-10-0/manufacture-10-0-quality_control/it/
@pedrobaeza
[MIG] quality_control: Migration to 11.0
105cf1b
@SimoRubi @pedrobaeza
[FIX+IMP] quality_control: Several things:
eb0771e 
* validation errors now raise exceptions.ValidationError, and other errors raise UserError
* Treaceability of inspection status
* using fa icons instead of gtk
* get ir_sequence.get method is deprecated
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
f1b9f09
@pedrobaeza pedrobaeza force-pushed the 11.0-mig-quality_control branch from 3567946 to 105cf1b Compare August 30, 2018 06:19
@pedrobaeza pedrobaeza merged commit a27272e into OCA:11.0 Aug 30, 2018
@ProcessControl-JHF ProcessControl-JHF deleted the 11.0-mig-quality_control branch August 30, 2018 07:52
@SalahAdDin
Copy link
Contributor

@jhumfer
I think i found a problem:
noestalogo
It is the same in the dashboard, but i don't know why.

@ProcessControl-JHF
Copy link
Author

@SalahAdDin If you add the text quality_control,static/description/icon.png to the field Web icon File from the Quality Control menu, the image appears in the dashboard

@SalahAdDin
Copy link
Contributor

But it must be done here in the module because other modules are working correctly.

@pedrobaeza
Copy link
Member

Please propose any of you the improvement. The module should adapt also to new design guidelines, but that's another history.

@SalahAdDin
Copy link
Contributor

@jhumfer Yes, you are right,
@pedrobaeza Should i make a small pull request for this?

@pedrobaeza
Copy link
Member

Please

@SalahAdDin
Copy link
Contributor

#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.