-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] mrp_mto_with_stock #255
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
42d3e24
[ADD] mrp_mto_with_stock - initial commit
michaeljohn32 7c02c01
[9.0][IMP] mrp_mto_with_stock: adapt to OCA and minor fixes.
LoisRForgeFlow ad94d92
[9.0][REW] mrp_mto_with_stock: Rework to remove dependency and enhanc…
LoisRForgeFlow 9f1f676
[IMP] should not auto-confirm the MO. Added test cases
JordiBForgeFlow 94699f0
add contributor email
LoisRForgeFlow 6345f15
Migrate and improve mrp_to_mto_with_stock to version 10
florian-dacosta 5d8596e
OCA Transbot updated translations from Transifex
oca-transbot d8b0674
OCA Transbot updated translations from Transifex
oca-transbot dab59bc
[11.0][MIG] mrp_mto_with_stock
af86bde
Fix mto_with_no_move_dest_id option + avoid useless procurement group…
florian-dacosta 334f206
Merge pull request #1 from akretion/11-mig-mrp_mto_with_stock
max3903 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of mto_with_no_move_dest_id, you need to remove 'move_dest_ids' from values.
Else the 2 case handled in this module are the same.
Indeed, with mto_with_no_move_dest_id, we want to buy/manufacture to make the future qty (virtual qty) = 0
but we do not want to link the purchase/manufacture order to the stock move.
It would be nice to add a small test to show this issue.
It can be easily done, for instance, adding
after https://github.com/ursais/manufacture/blob/dab59bcc211b61bab0f67486818bdaed38539e2a/mrp_mto_with_stock/tests/test_mrp_mto_with_stock.py#L77
Indeed, if you add this test with the present code, it will fail because the raw moves have ancestor and they should not.
Of course, the rest of the test may need to be adapted.