Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mrp_bom_component_menu #1224

Merged
merged 35 commits into from
Mar 25, 2024

Conversation

AnaisLForgeFlow
Copy link
Contributor

Standard migration

@ForgeFlow

JordiBForgeFlow and others added 30 commits March 7, 2024 11:57
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-12.0/manufacture-12.0-mrp_bom_component_menu
Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-mrp_bom_component_menu/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-13.0/manufacture-13.0-mrp_bom_component_menu
Translate-URL: https://translation.odoo-community.org/projects/manufacture-13-0/manufacture-13-0-mrp_bom_component_menu/
Currently translated at 100.0% (8 of 8 strings)

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_component_menu
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_component_menu/it/
Ivorra78 and others added 4 commits March 7, 2024 11:57
Currently translated at 100.0% (8 of 8 strings)

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_component_menu
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_component_menu/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: manufacture-16.0/manufacture-16.0-mrp_bom_component_menu
Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_component_menu/
Copy link
Contributor

@AndreuOForgeFlow AndreuOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code and functional review 👍🏽

Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from these minor comments, the rest looks perfect 😄

mrp_bom_component_menu/readme/USAGE.md Outdated Show resolved Hide resolved
mrp_bom_component_menu/__manifest__.py Outdated Show resolved Hide resolved
mrp_bom_component_menu/views/mrp_bom_component_view.xml Outdated Show resolved Hide resolved
@AnaisLForgeFlow AnaisLForgeFlow force-pushed the 17.0-mig-mrp_bom_component_menu branch from 8ee7901 to a855add Compare March 8, 2024 12:02
@AnaisLForgeFlow AnaisLForgeFlow force-pushed the 17.0-mig-mrp_bom_component_menu branch from a855add to 29fb287 Compare March 11, 2024 09:32
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code and functional review 👍🏽

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

/ocabot migration mrp_bom_component_menu

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 25, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 25, 2024
22 tasks
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1224-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c016872 into OCA:17.0 Mar 25, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 20e2721. Thanks a lot for contributing to OCA. ❤️

@GuillemCForgeFlow GuillemCForgeFlow deleted the 17.0-mig-mrp_bom_component_menu branch March 25, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.