Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] event_sale_reservation: Migration to version 17.0 #421

Merged
merged 16 commits into from
Dec 20, 2024

Conversation

pilarvargas-tecnativa
Copy link

cc @Tecnativa TT51924

@victoralmau @chienandalu please review

Jairo Llopis and others added 15 commits December 16, 2024 07:54
This module extends the functionality of event_sale to support selling
reservations of events that still don't exist and to allow you to schedule the
creation of events based on how many reservations already exist.

Includes integration workaround to avoid test conflicts with
`event_sale_registration_multi_qty`.

@Tecnativa TT27664

[UPD] Update event_sale_reservation.pot

[UPD] README.rst
TT31321

[UPD] Update event_sale_reservation.pot

[UPD] README.rst
Currently translated at 100.0% (32 of 32 strings)

Translation: event-15.0/event-15.0-event_sale_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/it/
Currently translated at 100.0% (32 of 32 strings)

Translation: event-15.0/event-15.0-event_sale_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: event-15.0/event-15.0-event_sale_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/
Currently translated at 100.0% (32 of 32 strings)

Translation: event-15.0/event-15.0-event_sale_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/es/
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-event_sale_reservation branch 2 times, most recently from cf76542 to c42b471 Compare December 18, 2024 09:27
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One behavior I detected is that when you register the reservation into an event, the ticket price overwrites the quotation one. I compared with the previous version and that didn't happen. Can you check it?

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-event_sale_reservation branch from c42b471 to 240cdcb Compare December 18, 2024 14:34
@pilarvargas-tecnativa
Copy link
Author

One behavior I detected is that when you register the reservation into an event, the ticket price overwrites the quotation one. I compared with the previous version and that didn't happen. Can you check it?

By converting the reserve product into the registration product, the price of the registration product was being set. Forcing the data when creating the registration from the booking keeps the price. The correct behaviour is the one you define. Tested also with real data.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@pedrobaeza
Copy link
Member

/ocabot migration event_sale_reservation

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 19, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 19, 2024
19 tasks
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK.

event_sale_reservation/__manifest__.py Outdated Show resolved Hide resolved
event_sale_reservation/tests/test_event_sale.py Outdated Show resolved Hide resolved
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-event_sale_reservation branch from 240cdcb to 4ce5a7b Compare December 19, 2024 14:49
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-421-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d94078a into OCA:17.0 Dec 20, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0299acb. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-event_sale_reservation branch December 20, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants