-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] event_sale_reservation: Migration to version 17.0 #421
[17.0][MIG] event_sale_reservation: Migration to version 17.0 #421
Conversation
This module extends the functionality of event_sale to support selling reservations of events that still don't exist and to allow you to schedule the creation of events based on how many reservations already exist. Includes integration workaround to avoid test conflicts with `event_sale_registration_multi_qty`. @Tecnativa TT27664 [UPD] Update event_sale_reservation.pot [UPD] README.rst
TT31321 [UPD] Update event_sale_reservation.pot [UPD] README.rst
Currently translated at 100.0% (32 of 32 strings) Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/it/
Currently translated at 100.0% (32 of 32 strings) Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/
Currently translated at 100.0% (32 of 32 strings) Translation: event-15.0/event-15.0-event_sale_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-event_sale_reservation/es/
cf76542
to
c42b471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One behavior I detected is that when you register the reservation into an event, the ticket price overwrites the quotation one. I compared with the previous version and that didn't happen. Can you check it?
c42b471
to
240cdcb
Compare
By converting the reserve product into the registration product, the price of the registration product was being set. Forcing the data when creating the registration from the booking keeps the price. The correct behaviour is the one you define. Tested also with real data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
/ocabot migration event_sale_reservation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review OK.
240cdcb
to
4ce5a7b
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 0299acb. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT51924
@victoralmau @chienandalu please review