[17.0][FIX] website_event_filter_city: Country filter support

[pilarvargas-tecnativa]

When the country filter is inactive, the node used is a span but when the country filter is activated with the editor, the node is replaced by a div and this causes an error. To avoid this, the node is replaced by something generic ‘*’ and so it will be located by its identifying class regardless of whether the element is a span or a div.

cc @Tecnativa

@chienandalu @carlos-lopez-tecnativa please review

[OCA-git-bot]

Hi @yajo,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Take the occasion to change the maintainer to us, as we are the effective maintainers of the module now.

[carlos-lopez-tecnativa]

It’s a bit strange; I can't reproduce the issue on any Runboat instance, but in this specific instance, the error is present. Thanks for the fix.

http://oca-event-17-0-030f8b6af6fc.runboat.odoo-community.org/

Note: I think it’s a bad practice from Odoo Base if the original view uses a <span> element and another view replaces it and changes it by <div>. Could you create an issue on the Odoo repository?

Original view
https://github.com/odoo/odoo/blob/f6fc5f889d041e471ec3af0fa9ec931e00923be3/addons/website_event/views/event_templates_list.xml#L120

Inherited view
https://github.com/odoo/odoo/blob/f6fc5f889d041e471ec3af0fa9ec931e00923be3/addons/website_event/views/event_templates_list.xml#L225-L237

[pilarvargas-tecnativa]

It’s a bit strange; I can't reproduce the issue on any Runboat instance, but in this specific instance, the error is present.

Sometimes runboats are not entirely correct in terms of templates or styles, they can fail and I don't know why, but we always have the option of testing the branch locally.

[chienandalu]

thanks :)

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-420-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

@pedrobaeza The merge process could not be finalized, because command git push origin 17.0-ocabot-merge-pr-420-by-pedrobaeza-bump-minor:17.0 failed with output:

To https://github.com/OCA/event
 ! [remote rejected]   17.0-ocabot-merge-pr-420-by-pedrobaeza-bump-minor -> 17.0 (cannot lock ref 'refs/heads/17.0': is at cfce9b4e138172151f5f69754c95bbe32f1191c4 but expected f733d5fa7a381f7ca8eb46fc99cfd7e03d8fe4dd)
error: failed to push some refs to 'https://github.com/OCA/event'

[OCA-git-bot]

Congratulations, your PR was merged at cfce9b4. Thanks a lot for contributing to OCA. ❤️