Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] base_ubl: schemeID for GTIN is 0160 #892

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[16.0][FIX] base_ubl: schemeID for GTIN is 0160 #892

merged 1 commit into from
Oct 11, 2024

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Dec 15, 2023 •
edited
Loading

Added support for 0160 schemeID on top of GTIN

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@jbaudoux
Copy link
Contributor Author

@OCA/edi-maintainers Can we merge this simple fix?

etobella
etobella reviewed May 22, 2024
View reviewed changes
base_ubl/models/ubl.py Outdated
barcode_xpath = line_node.xpath(
"cac:Item/cac:StandardItemIdentification/cbc:ID[@schemeID='GTIN']",
"cac:Item/cac:StandardItemIdentification/cbc:ID[@schemeID='0160']",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can simplify it by using "cac:Item/cac:StandardItemIdentification/cbc:ID[@schemeID='0160'|@schemeID='GTIN']",

Can you test? (It would be awesome to use an old file and a new file in tests in order to ensure that everything works fine

Copy link
Contributor Author

@jbaudoux jbaudoux Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doen't work with | but works with or. I don't even need to repeat @schemeID. I added a test for the 2 possibilities

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@lmignon
Copy link
Contributor

lmignon commented Oct 10, 2024

@OCA/edi-maintainers someone to merge it PLZ?

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-892-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c54071 into OCA:16.0 Oct 11, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d4f8e4d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella left review comments

@simahawk simahawk simahawk approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbaudoux @lmignon @simahawk @OCA-git-bot @bosd @etobella