Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]base_ubl_payment: Add payment means to SEPA direct debit/credit … #861

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Nov 15, 2023

…transfer

Fixes:

image
When creating a peppol invoice.

Screenshot from:
https://test.peppolautoriteit.nl/validate

By adding:
image

@bosd bosd marked this pull request as ready for review November 15, 2023 22:05
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks so good to me 👍

Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, Makes sense 😆

@bosd
Copy link
Contributor Author

bosd commented Dec 28, 2023

@oca/maintainers, can we get a merge? 🙏

@bosd
Copy link
Contributor Author

bosd commented Feb 5, 2024

@alexis-via Is this one ok to you?

@bosd
Copy link
Contributor Author

bosd commented Mar 13, 2024

@etobella Can you please merge 🙏

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@bosd
Copy link
Contributor Author

bosd commented Mar 14, 2024

@etobella Is the oca bot sleeping?? 🤖 ?

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-861-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 023bed2 into OCA:14.0 Mar 14, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 023bed2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants