Skip to content

[18.0][MIG] crm_phonecall_planner: Migration to 18.0 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: 18.0
Choose a base branch
from

Conversation

juancarlosonate-tecnativa

yajo and others added 13 commits April 9, 2025 13:37
* [ADD][crm_phonecall_planner] Phonecall autoscheduler

A simple to use wizard that generates phonecall plannings under given criteria.

* fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

* fixup! fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

* fixup! fixup! fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

* fixup! fixup! fixup! fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

* fixup! fixup! fixup! fixup! fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

* fixup! fixup! fixup! fixup! fixup! fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

*  fixup! fixup! fixup! fixup! fixup! fixup! [ADD][crm_phonecall_planner] Phonecall autoscheduler

Reword weird paragraph
- Include context keys for avoiding mail operations overhead.
@juancarlosonate-tecnativa juancarlosonate-tecnativa force-pushed the 18.0-mig-crm_phonecall_planner branch from 14bf4a3 to 008c92a Compare April 9, 2025 11:38
@pedrobaeza
Copy link
Member

/ocabot migration crm_phonecall_planner

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Apr 9, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 9, 2025
15 tasks
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working fine, just a few minor changes.

@@ -0,0 +1,54 @@
Now, to actually generate the phone call planning:

1. Go to *Sales \> Phone Calls \> Planner*.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the readme

Suggested change
1. Go to *Sales \> Phone Calls \> Planner*.
1. Go to *CRM \> Phone Calls \> Planner*.

Comment on lines +21 to +42
"attendance_ids": [
(
0,
0,
{
"name": "Monday morning",
"dayofweek": "0",
"hour_from": 9,
"hour_to": 12,
},
),
(
0,
0,
{
"name": "Monday evening",
"dayofweek": "0",
"hour_from": 15,
"hour_to": 20,
},
),
],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the Command class? It’s more readable.

Suggested change
"attendance_ids": [
(
0,
0,
{
"name": "Monday morning",
"dayofweek": "0",
"hour_from": 9,
"hour_to": 12,
},
),
(
0,
0,
{
"name": "Monday evening",
"dayofweek": "0",
"hour_from": 15,
"hour_to": 20,
},
),
],
"attendance_ids": [
Command.create(
{
"name": "Monday morning",
"dayofweek": "0",
"hour_from": 9,
"hour_to": 12,
},
),
Command.create(
{
"name": "Monday evening",
"dayofweek": "0",
"hour_from": 15,
"hour_to": 20,
},
),
],

Comment on lines +18 to +20
_inherit = [
"utm.mixin",
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_inherit = [
"utm.mixin",
]
_inherit = "utm.mixin"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants