Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] crm_salesperson_planner: fix unit tests #633

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

MohamedOsman7
Copy link

  • Fix the error: "The date can't be earlier than today."
  • Remove warnings for buttons with the icons "fa-undo", "fa-calendar text-success", and "fa-check" due to missing titles ("A button with an icon attribute must have a title in its tag, parents, descendants, or have text")

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-imp-crm_salesperson_planner branch from 1190ce7 to 1b1b9e1 Compare February 28, 2025 16:13
@MohamedOsman7
Copy link
Author

@peluko00 @ppyczko could you please make a review

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-imp-crm_salesperson_planner branch from 1b1b9e1 to d311740 Compare February 28, 2025 16:21
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-633-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f90cc32 into OCA:17.0 Mar 8, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f00696b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants