Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] crm_project #495

Closed
wants to merge 15 commits into from

Conversation

SoporteOperu
Copy link

No description provided.

Copy link

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the sales/Administrator role is allowed to convert leads to tasks. However, according to the README.rst file,'Project User' and 'Salesman' roles have permissions to convert leads to tasks. When converting a lead to a task with the sales/User: Own Documents rights, an error occurs indicating that the user does not have the rights to delete the lead. Therefore, could you please update theREADME.rst file to specify the salesperson role and the corresponding rights required for conversion?

@rafaelbn
Copy link
Member

Hello @SoporteOperu ,

We would like to change the name of this module, many years ago of this development

"Lead to task"
"Convert lead to Task"

crm_project is not the correct name

@pedrobaeza @victoralmau do you agree?

I think about creating in OCA/crm a base_crm_project that creates relation between crm and project so other many OCA modules that need this dependency use it

  • crm_timesheet
  • crm_lead_to_task <- the name I recommend for this PR this migration "crm_project"
  • crm_project_task
  • etc...

Opinions are always are really welcome @yajo @EmilioPascual @Shide

/ocabot migration crm_project

Thank you! 😄

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 21, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 21, 2023
22 tasks
@pedrobaeza
Copy link
Member

pedrobaeza commented Jul 21, 2023

OK to crm_lead_to_task.

Rename the whole git history doing:

git filter-branch --tree-filter 'if [ -d crm_project ]; then mv crm_project crm_lead_to_task; fi' HEAD
git fetch origin 16.0
git rebase origin/16.0

@carolinafernandez-tecnativa
Copy link
Contributor

@SoporteOperu could you please rebase?

@rafaelbn
Copy link
Member

rafaelbn commented Oct 4, 2023

Hello @SoporteOperu are you going to continue this PR? A new update one is in #522 Thanks!

@rafaelbn
Copy link
Member

rafaelbn commented Oct 4, 2023

Superseed by #522

@rafaelbn rafaelbn closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants