[16.0][MIG] crm_phonecall: Migration to version 16.0 #490

stefan-tecnativa · 2023-05-08T07:55:14Z

@chienandalu @pilarvargas-tecnativa please review!

* crm_phonecall module (OCA#131) This module is the part extracted from Odoo v8 crm module from Odoo that allows to record phone calls. As it has been stripped off from Odoo v9, we add again the feature via this module. Migration scripts are also included to upgrade a v8 database via OpenUpgrade and don't lose your history. * [MIG] crm_phone_call: Migrated to 10.0 - FIX: Correct some lint errors * [MIG] crm_phone_call: Migrated to 10.0

…reated from phonecall2phonecall wizard.

…ut `date`

Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/

Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

…ve_id is not correct

Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

…bally from crm settings.

…change name to all groups for consistancy.

crm_phonecall/security/ir.model.access.csv

crm_phonecall/security/.~lock.ir.model.access.csv#

chienandalu · 2023-05-08T08:52:39Z

crm_phonecall/views/crm_phonecall_view.xml

        <field name="arch" type="xml">
            <tree position="attributes">
-                <attribute name="editable" />
+                <t groups="crm_phonecall.group_show_form_view">


This doesn't seem to work. Maybe there's a limitation for this technique when overriding attributes.

Still not working. You probably need to override _get_view and inject the attribute depending on the user's permission. Some reference on how to override such method (adapt it to your needs):

https://github.com/odoo/odoo/blob/7f6c463ccea5edf35e194e42728f62f4abe5eb9c/odoo/addons/base/models/res_currency.py#L318-L327

Done, I deleted that record as it is no longer needed with these aproach. Can you check anyway if it is correct please?

You have to move the groups to the elements of the view, instead of the whole view. Does the group still exist?

crm_phonecall/views/res_partner_view.xml

CarlosRoca13

It LGTM 👍

crm_phonecall/README.rst

pilarvargas-tecnativa

thanks 👍

chienandalu · 2023-05-18T16:03:34Z

crm_phonecall/models/crm_phonecall.py

+        """This is done for injecting the attribute depending on the user's permissions
+        as moving the group of the view attribute element didn't work and no similar examples
+        of use where found either"""


Suggested change

"""This is done for injecting the attribute depending on the user's permissions

as moving the group of the view attribute element didn't work and no similar examples

of use where found either"""

"""Inject group check to make the tree editable or not. Apparently it can't be done

by pure view inheritance and attribute overriding"""

OCA-git-bot · 2023-05-30T07:33:43Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-05-30T07:33:43Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2023-05-30T20:46:41Z

/ocabot merge nobump

OCA-git-bot · 2023-05-30T20:46:59Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-490-by-pedrobaeza-bump-nobump, awaiting test results.

pedrobaeza · 2023-05-30T20:47:06Z

/ocabot migration crm_phonecall

OCA-git-bot · 2023-05-30T20:51:06Z

Congratulations, your PR was merged at 1d2dd01. Thanks a lot for contributing to OCA. ❤️

cubells and others added 30 commits April 27, 2023 13:38

[IMP] Add smartbutton to leads and opportunities

1d81bea

[IMP][crm_phonecall] Add utm.mixin fields

bf61e8e

crm_phonecall: Fix action to redirect to the new phonecall when its c…

b1d257e

…reated from phonecall2phonecall wizard.

[FIX] crm_phonecall: C8108(method-compute) + E8103(sql-injection)

f614626

[MIG] crm_phonecall: Migration to 11.0

2dbc4b8

crm_phonecall: fixes to skip duration computation on phonecalls witho…

1cfece0

…ut `date`

[MIG] crm_phonecall: Migration to 12.0.

db8e51e

Translated using Weblate (Spanish)

7f30ee0

Currently translated at 100.0% (150 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/es/

Translated using Weblate (German)

f7ab576

Currently translated at 86.0% (129 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

[FIX] crm_phonecall: make states editable

1549afc

[FIX] crm_phonecall: when accessing from partner's opportunities acti…

22164be

…ve_id is not correct

Translated using Weblate (German)

7fd744b

Currently translated at 92.7% (139 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

Translated using Weblate (German)

477176f

Currently translated at 98.0% (147 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/de/

[FIX] crm_phonecall button size

e2c40bc

Translated using Weblate (Croatian)

4bc8210

Currently translated at 27.3% (41 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

[IMP] crm_phonecall UI Phonecall button next to Meetings

98a0103

Translated using Weblate (Croatian)

558068d

Currently translated at 41.3% (62 of 150 strings) Translation: crm-12.0/crm-12.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall/hr/

[IMP] crm_phonecall: black, isort

69ee1b1

[MIG] crm_phonecall: Migration to 13.0

67e1757

[UPD] Update crm_phonecall.pot

df043fd

pre-commit update

6aaab27

Update translation files

3937e9a

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: crm-13.0/crm-13.0-crm_phonecall Translate-URL: https://translation.odoo-community.org/projects/crm-13-0/crm-13-0-crm_phonecall/

[IMP] crm_phonecall: Add field direction in calls and improve views.

3336b2b

[IMP] crm_phonecall: Add new group to enable form view for phone calls.

faa0293

[IMP] crm_phonecall: Add field direction in tree view of phone calls.

e1835e2

[IMP] crm_phonecall: Add config setting to allow enable form view glo…

2d34058

…bally from crm settings.

[FIX] crm_phonecall: Fix group by state in search view of calls, and …

bbd1ad0

…change name to all groups for consistancy.

[UPD] Update crm_phonecall.pot

4873be7

[UPD] README.rst

479f264

[IMP] crm_phonecall: pre-commit stuff

7bd4cde

chienandalu suggested changes May 8, 2023

View reviewed changes

stefan-tecnativa force-pushed the 16.0-mig-crm_phonecall branch 3 times, most recently from e19efbf to c91e5fd Compare May 9, 2023 08:50

CarlosRoca13 approved these changes May 9, 2023

View reviewed changes

pilarvargas-tecnativa reviewed May 15, 2023

View reviewed changes

crm_phonecall/README.rst Outdated Show resolved Hide resolved

pilarvargas-tecnativa reviewed May 15, 2023

View reviewed changes

crm_phonecall/README.rst Outdated Show resolved Hide resolved

stefan-tecnativa force-pushed the 16.0-mig-crm_phonecall branch from c91e5fd to 4e7a1a2 Compare May 15, 2023 09:22

pilarvargas-tecnativa approved these changes May 15, 2023

View reviewed changes

stefan-tecnativa force-pushed the 16.0-mig-crm_phonecall branch from 4e7a1a2 to aceb8ec Compare May 18, 2023 13:02

chienandalu reviewed May 18, 2023

View reviewed changes

[MIG] crm_phonecall: Migration to 16.0

715eabe

stefan-tecnativa force-pushed the 16.0-mig-crm_phonecall branch from aceb8ec to 715eabe Compare May 19, 2023 05:51

chienandalu approved these changes May 30, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels May 30, 2023

OCA-git-bot added the bot is merging ⏳ label May 30, 2023

OCA-git-bot added this to the 16.0 milestone May 30, 2023

OCA-git-bot mentioned this pull request May 30, 2023

Migration to version 16.0 #443

Open

22 tasks

OCA-git-bot merged commit 6fc323c into OCA:16.0 May 30, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] crm_phonecall: Migration to version 16.0 #490

[16.0][MIG] crm_phonecall: Migration to version 16.0 #490

stefan-tecnativa commented May 8, 2023

chienandalu May 8, 2023

chienandalu May 8, 2023

stefan-tecnativa May 9, 2023

pedrobaeza May 15, 2023

CarlosRoca13 left a comment

pilarvargas-tecnativa left a comment

chienandalu May 18, 2023

OCA-git-bot commented May 30, 2023

OCA-git-bot commented May 30, 2023

pedrobaeza commented May 30, 2023

OCA-git-bot commented May 30, 2023

pedrobaeza commented May 30, 2023

OCA-git-bot commented May 30, 2023

[16.0][MIG] crm_phonecall: Migration to version 16.0 #490

[16.0][MIG] crm_phonecall: Migration to version 16.0 #490

Conversation

stefan-tecnativa commented May 8, 2023

chienandalu May 8, 2023

Choose a reason for hiding this comment

chienandalu May 8, 2023

Choose a reason for hiding this comment

stefan-tecnativa May 9, 2023

Choose a reason for hiding this comment

pedrobaeza May 15, 2023

Choose a reason for hiding this comment

CarlosRoca13 left a comment

Choose a reason for hiding this comment

pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

chienandalu May 18, 2023

Choose a reason for hiding this comment

OCA-git-bot commented May 30, 2023

OCA-git-bot commented May 30, 2023

pedrobaeza commented May 30, 2023

OCA-git-bot commented May 30, 2023

pedrobaeza commented May 30, 2023

OCA-git-bot commented May 30, 2023