Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] crm_security_group: Migration to 15.0 #451

Merged
merged 5 commits into from
Nov 8, 2022
Merged

[15.0][MIG] crm_security_group: Migration to 15.0 #451

merged 5 commits into from
Nov 8, 2022

Conversation

victoralmau
Copy link
Member

Migration to 15.0

@Tecnativa TT40356

@victoralmau
[ADD] crm_security_group: Add new category about CRM and create 3 gro…
b715841 
…ups (Own Documents Only, All Documents and Administrator) to separate Sales and CRM apps
@victoralmau
[IMP] crm_security_group: black, isort, prettier
306406e
@victoralmau
[MIG] crm_security_group: Migration to 14.0
07dec4c 
[UPD] Update crm_security_group.pot

[UPD] README.rst

crm_security_group 14.0.1.0.1
@victoralmau
[IMP] crm_security_group: black, isort, prettier
d44358f
@victoralmau victoralmau force-pushed the 15.0-mig-crm_security_group branch from 062f6ef to b260c1f Compare November 4, 2022 12:28
@pedrobaeza
Copy link
Member

/ocabot migration crm_security_group

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 8, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 8, 2022
Closed
16 tasks
pedrobaeza
pedrobaeza requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat:

  • Put the permissions on the Sales section, not a new one CRM.
  • If I don't put any permission in CRM, I'm still seeing the CRM section.

@victoralmau victoralmau force-pushed the 15.0-mig-crm_security_group branch from b260c1f to e076eb7 Compare November 8, 2022 11:28
@victoralmau victoralmau force-pushed the 15.0-mig-crm_security_group branch from e076eb7 to 8b0b4ab Compare November 8, 2022 11:33
fcvalgar
fcvalgar approved these changes Nov 8, 2022
View reviewed changes
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-451-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8b13404 into OCA:15.0 Nov 8, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d6b752b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@fcvalgar fcvalgar fcvalgar approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @fcvalgar