Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] crm_industry: Migration to 13.0 #334

Merged
merged 17 commits into from
Jul 5, 2020
Merged

[13.0][MIG] crm_industry: Migration to 13.0 #334

merged 17 commits into from
Jul 5, 2020

Conversation

skeller1
Copy link
Contributor

Standard Migration of crm_industry to 13.0

Depends on OCA/partner-contact#916

@rousseldenis rousseldenis added this to the 13.0 milestone May 18, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request May 18, 2020
Closed
17 tasks
mamcode
mamcode approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@mamcode mamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, travis is not passing but I can't see the logs (the server is showing error 404), locally I see that pre-commit is passing, the unit test is passing and functionally is all right.
Thanks for this migration.

@mamcode
Copy link
Member

mamcode commented Jun 16, 2020

Maybe you can squash the commits of translations to make commit history look better.

MiquelRForgeFlow and others added 17 commits July 3, 2020 23:00
@MiquelRForgeFlow @skeller1
crm_sector -> crm_industry
685f3fc
@MiquelRForgeFlow @skeller1
Migration scripts (from v10 to v11)
21fe368
@OCA-git-bot @skeller1
README.rst
7057c49
@oca-travis @skeller1
Update crm_industry.pot
8e50b8b
@marylla @skeller1
Translated using Weblate (German)
a78118b 
Currently translated at 100.0% (5 of 5 strings)

Translation: crm-11.0/crm-11.0-crm_industry
Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-crm_industry/de/
@mvrodriguez @skeller1
Translated using Weblate (Spanish)
4389b95 
Currently translated at 100.0% (5 of 5 strings)

Translation: crm-11.0/crm-11.0-crm_industry
Translate-URL: https://translation.odoo-community.org/projects/crm-11-0/crm-11-0-crm_industry/es/
@Tardo @skeller1
crm_industry: Migration to 12.0
39f3c15
@oca-travis @skeller1
Update crm_industry.pot
33f91c5
@oca-transbot @skeller1
Update translation files
266782f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-12.0/crm-12.0-crm_industry
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_industry/
@OCA-git-bot @skeller1
README.rst
6a9efd5
@skeller1
Translated using Weblate (Portuguese (Brazil))
7d59207 
Currently translated at 100.0% (5 of 5 strings)

Translation: crm-12.0/crm-12.0-crm_industry
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_industry/pt_BR/
@CarlesAntoli @skeller1
Added translation using Weblate (Catalan)
332aaf8
@CarlesAntoli @skeller1
Added translation using Weblate (Catalan)
1a86fd4
@CarlesAntoli @skeller1
Translated using Weblate (Catalan)
a39a410 
Currently translated at 100.0% (5 of 5 strings)

Translation: crm-12.0/crm-12.0-crm_industry
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_industry/ca/
@primes2h @skeller1
Translated using Weblate (Italian)
d4386bb 
Currently translated at 20.0% (1 of 5 strings)

Translation: crm-12.0/crm-12.0-crm_industry
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_industry/it/
@skeller1
[IMP] crm_industry: black, isort, prettier
0234333
@skeller1
[MIG] crm_industry: Migration to 13.0
9e58f6a
@skeller1 skeller1 force-pushed the 13.0-mig-crm_industry branch from ff86e1c to 9e58f6a Compare July 3, 2020 21:01
@skeller1
Copy link
Contributor Author

skeller1 commented Jul 3, 2020

LGTM, travis is not passing but I can't see the logs (the server is showing error 404), locally I see that pre-commit is passing, the unit test is passing and functionally is all right.
Thanks for this migration.

LGTM, travis is not passing but I can't see the logs (the server is showing error 404), locally I see that pre-commit is passing, the unit test is passing and functionally is all right.
Thanks for this migration.
This addon depends on partner_industry_secondary addon. MR has been merged in partner-contact repo.
Did Push Force and pipe is running now. We will see.
Thank you

@skeller1 skeller1 closed this Jul 3, 2020
@skeller1 skeller1 reopened this Jul 3, 2020
HaraldPanten
HaraldPanten approved these changes Jul 4, 2020
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-334-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cdad9c6 into OCA:13.0 Jul 5, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b1125ed. Thanks a lot for contributing to OCA. ❤️

@skeller1 skeller1 deleted the 13.0-mig-crm_industry branch July 7, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamcode mamcode mamcode approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.