Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] crm_phonecall_summary_predefined #324

Merged
merged 21 commits into from
Jul 17, 2020
Merged

[13.0][MIG] crm_phonecall_summary_predefined #324

merged 21 commits into from
Jul 17, 2020

Conversation

HaraldPanten
Copy link
Contributor

@HaraldPanten HaraldPanten commented May 6, 2020 •
edited
Loading

Ready to review

yajo and others added 20 commits May 6, 2020 13:06
@yajo @HaraldPanten
Restricted list of possible summaries for phone calls
a2fe20c 
This module fills the gap of phone marketing companies where phone call summaries can only belong to a limited amount of possibilities.
@oca-transbot @HaraldPanten
OCA Transbot updated translations from Transifex
3573d79
@cubells @HaraldPanten
crm_phonecall_summary_predefined module - Updated views - Updated README
7727e80
@cubells @HaraldPanten
[MIG][10.0] crm_phonecall_summary_predefined module
a015c42
@oca-transbot @HaraldPanten
OCA Transbot updated translations from Transifex
d9bc044
@oca-travis @HaraldPanten
[UPD] Update crm_phonecall_summary_predefined.pot
ed0b820
@cristinamartinrod @HaraldPanten
[MIG] crm_phonecall_summary_predefined: Migration to 11.0
d91d41e
@oca-travis @HaraldPanten
[MIG] crm_phonecall_summary_predefined: Migration to 12.0.
1e31d39
@OCA-git-bot @HaraldPanten
[UPD] README.rst
6394f9f
@oca-travis @HaraldPanten
[UPD] Update crm_phonecall_summary_predefined.pot
3d18973
@emagdalenaC2i @HaraldPanten
Translated using Weblate (Spanish)
3f49ca0 
Currently translated at 100.0% (15 of 15 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/es/
@oca-transbot @HaraldPanten
Update translation files
43429d9 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/
@marylla @HaraldPanten
Translated using Weblate (German)
43a8e4b 
Currently translated at 50.0% (8 of 16 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/de/
@OCA-git-bot @HaraldPanten
[UPD] README.rst
9f397ba
@HaraldPanten
Translated using Weblate (Portuguese (Brazil))
ea5abd0 
Currently translated at 100.0% (16 of 16 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/pt_BR/
@badbole @HaraldPanten
Translated using Weblate (Croatian)
7ea3b76 
Currently translated at 100.0% (16 of 16 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/hr/
@primes2h @HaraldPanten
Translated using Weblate (Italian)
74bb423 
Currently translated at 100.0% (16 of 16 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/it/
@ruthbeat @HaraldPanten
Translated using Weblate (Spanish)
1c02083 
Currently translated at 100.0% (16 of 16 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/es/
@sysadminmatmoz @HaraldPanten
Translated using Weblate (Slovenian)
ce3c330 
Currently translated at 100.0% (16 of 16 strings)

Translation: crm-12.0/crm-12.0-crm_phonecall_summary_predefined
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_phonecall_summary_predefined/sl/
@HaraldPanten
[IMP] crm_phonecall_summary_predefined: black, isort, prettier
22e62bf
@HaraldPanten HaraldPanten mentioned this pull request May 6, 2020
Closed
17 tasks
@HaraldPanten HaraldPanten force-pushed the 13.0-mig-crm_phonecall_summary_predefined branch from 28fddd8 to 1290dc1 Compare May 6, 2020 12:10
@HaraldPanten HaraldPanten changed the title [13.0][WIP][MIG] crm_phonecall_summary_predefined [13.0][MIG] crm_phonecall_summary_predefined May 6, 2020
@HaraldPanten
Copy link
Contributor Author

@ValentinVinagre could you review, please?

@HaraldPanten HaraldPanten force-pushed the 13.0-mig-crm_phonecall_summary_predefined branch from 1290dc1 to f55f5c0 Compare May 6, 2020 12:50
@rousseldenis rousseldenis added this to the 13.0 milestone May 7, 2020
skeller1
skeller1 suggested changes May 10, 2020
View reviewed changes
Copy link
Contributor

@skeller1 skeller1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 LGTM
Maybe you could update the two images in the docs

Got this error using wizard Schedule Other Call. Maybe this is a bug already available in V12
ScheduleOtherCall

Thank you for contrib

@HaraldPanten HaraldPanten force-pushed the 13.0-mig-crm_phonecall_summary_predefined branch from f55f5c0 to 58dc127 Compare May 11, 2020 07:59
@HaraldPanten
Copy link
Contributor Author

Overall 👍 LGTM
Maybe you could update the two images in the docs

Got this error using wizard Schedule Other Call. Maybe this is a bug already available in V12
ScheduleOtherCall

Thank you for contrib

You're right. It's an issue comming from V12 as well.

I'll have a look and I'll prepare a new PR fixing this.

Thank you so much for your review! 👍

@skeller1
Copy link
Contributor

crm_phonecall_summary_predefined is also introducing errors for crm_phonecall_planner and crm_phonecall_timesheet addons. The missing field summary_id. We should optimize crm_phonecall to be more extendable (add missing field in vals_list or something)

Thank you for investigation 👍

@ValentinVinagre ValentinVinagre mentioned this pull request May 11, 2020
Merged
@ValentinVinagre ValentinVinagre force-pushed the 13.0-mig-crm_phonecall_summary_predefined branch from 58dc127 to d45dbc6 Compare May 11, 2020 14:12
@HaraldPanten
Copy link
Contributor Author

HaraldPanten commented May 11, 2020 •
edited
Loading

Overall 👍 LGTM
Maybe you could update the two images in the docs

Got this error using wizard Schedule Other Call. Maybe this is a bug already available in V12
ScheduleOtherCall

Thank you for contrib

Depends on #327 👍

@ValentinVinagre
Copy link
Contributor

Hi @HaraldPanten the #327 has been merged.

@ValentinVinagre ValentinVinagre force-pushed the 13.0-mig-crm_phonecall_summary_predefined branch from d45dbc6 to a37c488 Compare May 13, 2020 11:59
@rafaelbn
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-324-by-rafaelbn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 17, 2020
@OCA-git-bot
Merge PR #324 into 13.0
8ca42d6 
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-324-by-rafaelbn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9777886 into OCA:13.0 Jul 17, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 01e9ad4. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 13.0-mig-crm_phonecall_summary_predefined branch July 22, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeller1 skeller1 skeller1 approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.