Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] crm_lead_product #303

Merged
merged 12 commits into from
Feb 27, 2020
Merged

[13.0][MIG] crm_lead_product #303

merged 12 commits into from
Feb 27, 2020

Conversation

JoanSForgeFlow
Copy link

@JoanSForgeFlow JoanSForgeFlow commented Jan 9, 2020 •
edited
Loading

crm_lead_product migration to v13

cc ~ @ForgeFlow @LoisRForgeFlow @JordiBForgeFlow

AdriaGForgeFlow and others added 10 commits January 8, 2020 16:51
@AdriaGForgeFlow @JoanSForgeFlow
[12.0][ADD] Add new module crm_lead_product
e1d94d1 
add filter for open opportunities in pipeline by product report

[IMP] Extend test coverage
@OCA-git-bot @JoanSForgeFlow
[UPD] README.rst
0cff9af
@oca-travis @JoanSForgeFlow
[UPD] Update crm_lead_product.pot
0954cec
@mvrodriguez @JoanSForgeFlow
Added translation using Weblate (Spanish)
5f9affe
@mvrodriguez @JoanSForgeFlow
Translated using Weblate (Spanish)
947d673 
Currently translated at 100.0% (63 of 63 strings)

Translation: crm-12.0/crm-12.0-crm_lead_product
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_product/es/
@OCA-git-bot @JoanSForgeFlow
[UPD] README.rst
b4d37b4
@CarlesAntoli @JoanSForgeFlow
Added translation using Weblate (Catalan)
c48591b
@CarlesAntoli @JoanSForgeFlow
Added translation using Weblate (Catalan)
7c074f0
@CarlesAntoli @JoanSForgeFlow
Translated using Weblate (Catalan)
81d4a21 
Currently translated at 100.0% (63 of 63 strings)

Translation: crm-12.0/crm-12.0-crm_lead_product
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_product/ca/
@JoanSForgeFlow
[IMP] crm_lead_product: black, isort
f737dc2
@JoanSForgeFlow JoanSForgeFlow force-pushed the 13.0-mig-crm_lead_product branch 2 times, most recently from 38b18be to 4420402 Compare January 9, 2020 09:35
@JoanSForgeFlow JoanSForgeFlow force-pushed the 13.0-mig-crm_lead_product branch from 4420402 to 6ff9964 Compare January 9, 2020 16:08
AdriaGForgeFlow
AdriaGForgeFlow approved these changes Jan 10, 2020
View reviewed changes
Copy link

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot 👍

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 15, 2020
View reviewed changes
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordiBForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-303-by-JordiBForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 4, 2020
@OCA-git-bot
Merge PR #303 into 13.0
659cd9a 
Signed-off-by JordiBForgeFlow
@OCA-git-bot
Copy link
Contributor

@JordiBForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-303-by-JordiBForgeFlow-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@JordiBForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-303-by-JordiBForgeFlow-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 4, 2020
@OCA-git-bot
Merge PR #303 into 13.0
663ff02 
Signed-off-by JordiBForgeFlow
@OCA-git-bot
Copy link
Contributor

@JordiBForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-303-by-JordiBForgeFlow-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@JoanSForgeFlow
[13.0][FIX] crm_lead_product:
5999ec6 
* avoid conflict when testing a database with sale installed
@JoanSForgeFlow JoanSForgeFlow force-pushed the 13.0-mig-crm_lead_product branch from 6ff9964 to 5999ec6 Compare February 5, 2020 07:52
@JordiBForgeFlow
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-303-by-JordiBForgeFlow-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 08b30b9 into OCA:13.0 Feb 27, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at babc0a6. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-mig-crm_lead_product branch February 27, 2020 13:09
@tonygalmiche tonygalmiche mentioned this pull request May 28, 2020
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@JoanSForgeFlow @OCA-git-bot @JordiBForgeFlow @AaronHForgeFlow @MiquelRForgeFlow @AdriaGForgeFlow @oca-travis @mvrodriguez @CarlesAntoli